[Marble-devel] Review Request 114144: Fixed / Improved default selection of checkboxes, radio buttons, comboboxes in Marble Legend Browser

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114144/#review44616
-----------------------------------------------------------



src/lib/marble/MarbleLegendBrowser.cpp
<http://git.reviewboard.kde.org/r/114144/#comment31835>

    Should be constructed without arguments. This way the ones set in QCoreApplication are used, which automatically save to the right file.
    



src/lib/marble/MarbleLegendBrowser.cpp
<http://git.reviewboard.kde.org/r/114144/#comment31837>

    what's the purpose of this property?



src/lib/marble/MarbleLegendBrowser.cpp
<http://git.reviewboard.kde.org/r/114144/#comment31834>

    Should be constructed without arguments. This way the ones set in QCoreApplication are used, which automatically save to the right file.
    



src/lib/marble/MarbleLegendBrowser.cpp
<http://git.reviewboard.kde.org/r/114144/#comment31836>

    curly brackets missing (required also for one-liners)



src/lib/marble/geodata/parser/GeoSceneTypes.cpp
<http://git.reviewboard.kde.org/r/114144/#comment31833>

    How is this related to the patch? Why is GeoSceneOption deleted below? I don't find that file in git master, nor in git history.
    



src/plugins/declarative/MarbleSettings.qml
<http://git.reviewboard.kde.org/r/114144/#comment31832>

    Looks wrong to me


- Dennis Nienhüser


On Nov. 27, 2013, 3:11 p.m., Yazeed Zoabi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114144/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2013, 3:11 p.m.)
> 
> 
> Review request for Marble, Utku Aydın, Dennis Nienhüser, and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> The selection of checkboxes, radio buttons and comboBoxes now gets saved with this diff. (Selection gets saved when the user even restarts Marble).
> This depends on a previous review that did not got committed (the combobox support, the comments suggested by Torsten Rahn were fixed in THIS diff).
> comboBox review : https://git.reviewboard.kde.org/r/114082/ 
> 
> gci task: http://www.google-melange.com/gci/task/view/google/gci2013/5847900902916096
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/MarbleLegendBrowser.h e7fb4b5 
>   src/lib/marble/MarbleLegendBrowser.cpp 644dd0f 
>   src/lib/marble/geodata/handlers/DgmlOptionTagHandler.h e69de29 
>   src/lib/marble/geodata/handlers/DgmlOptionTagHandler.cpp e69de29 
>   src/lib/marble/geodata/handlers/dgml/DgmlAttributeDictionary.h d426e0d 
>   src/lib/marble/geodata/handlers/dgml/DgmlAttributeDictionary.cpp 20b0ebe 
>   src/lib/marble/geodata/handlers/dgml/DgmlSectionTagHandler.cpp 66ee562 
>   src/lib/marble/geodata/parser/GeoSceneTypes.h 5fd1cdb 
>   src/lib/marble/geodata/parser/GeoSceneTypes.cpp a653d02 
>   src/lib/marble/geodata/scene/GeoSceneOption.h e69de29 
>   src/lib/marble/geodata/scene/GeoSceneOption.cpp e69de29 
>   src/lib/marble/geodata/scene/GeoSceneSection.h 5224f43 
>   src/lib/marble/geodata/scene/GeoSceneSection.cpp 9d7bf77 
>   src/plugins/declarative/MarbleSettings.qml 06fd9cc 
> 
> Diff: http://git.reviewboard.kde.org/r/114144/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yazeed Zoabi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131127/c2cc6f24/attachment-0001.html>