[Marble-devel] Review Request 114156: Support for nautical miles added (as a measurement sys.)

Illya Kovalevskyy illya.kovalevskyy at gmail.com
Wed Nov 27 18:38:27 UTC 2013



> On Nov. 27, 2013, 8:31 p.m., Thibaut Gridel wrote:
> > Patch looks good.
> > Nm/h is a knot (kt). Please update where needed.
> > In a nautical system, altitude is either metric or feet, never nm.

So, what should we use for altitude?


- Illya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114156/#review44606
-----------------------------------------------------------


On Nov. 27, 2013, 7:08 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114156/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2013, 7:08 p.m.)
> 
> 
> Review request for Marble, Utku Aydın, Dennis Nienhüser, and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> According to Google Code-In 2013 task (http://www.google-melange.com/gci/task/view/google/gci2013/5839303452131328):
> 
> Nautical miles are introduced and implementation adjusted to the codebase.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/CurrentLocationWidget.cpp e7da170 
>   src/lib/marble/MarbleGlobal.h 5a5a917 
>   src/lib/marble/MarbleLocale.h 043338f 
>   src/lib/marble/MarbleWidget.cpp 5ee954d 
>   src/plugins/render/elevationprofilefloatitem/ElevationProfilePlotAxis.cpp e9d530a 
>   src/plugins/render/gpsinfo/GpsInfo.cpp fd00037 
>   src/plugins/render/mapscale/MapScaleFloatItem.cpp aa2ddad 
>   src/plugins/render/measure/MeasureToolPlugin.cpp 26a4174 
>   src/plugins/render/opencachingcom/OpenCachingComItem.cpp c8cae68 
>   src/plugins/render/routing/RoutingPlugin.cpp 86fbdd9 
>   src/plugins/render/speedometer/Speedometer.cpp d1e2bef 
>   src/plugins/runner/local-osm-search/OsmDatabase.cpp 47f50b6 
> 
> Diff: http://git.reviewboard.kde.org/r/114156/diff/
> 
> 
> Testing
> -------
> 
> Unit tests & user-testing
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131127/e94301e9/attachment-0001.html>


More information about the Marble-devel mailing list