[Marble-devel] Review Request 114092: Extend GPSBabel Plugin to support more file types.

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114092/#review44488
-----------------------------------------------------------



src/plugins/runner/gpsbabel/GpsbabelRunner.cpp
<http://git.reviewboard.kde.org/r/114092/#comment31782>

    Maybe we should just create a QStringList like this:
    
    QStringList supportedFormats;
    supportedFormats << "nmea" << "igc" << "tiger" ......... ;
    
    And then check for 
    
    if (supportedFormats.contains(fileSuffix)) { inputFile = fileSuffix;
    }
    else {
    ....}
    
    Would be easier on the eyes ...


- Torsten Rahn


On Nov. 25, 2013, 4:32 p.m., Daniel Lanzi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114092/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2013, 4:32 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Extended GpsBabel Plugin to support more file types. Added igc, tiger, tomtom, garmin_txt, magellan, csv, and gpx. 
> 
> 
> Diffs
> -----
> 
>   src/plugins/runner/gpsbabel/GpsbabelPlugin.cpp eeb986c 
>   src/plugins/runner/gpsbabel/GpsbabelRunner.cpp e9512ef 
> 
> Diff: http://git.reviewboard.kde.org/r/114092/diff/
> 
> 
> Testing
> -------
> 
> Created a gpx test track with a gps receiver. Played through gpsbabel to create the other file types. Opened with marble.
> 
> 
> Thanks,
> 
> Daniel Lanzi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131126/b2749b6e/attachment-0001.html>