[Marble-devel] Review Request 114089: [GCI] kwallet support for owncloud sync

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114089/#review44391
-----------------------------------------------------------



src/apps/marble-kde/marble_part.cpp
<http://git.reviewboard.kde.org/r/114089/#comment31750>

    I'm not a native English speaker but I guess this text would be nicer:
    
    You haven't allowed Marble to use KWallet yet.
    This is dangerous since Marble will store your password without encryption.
    Are you sure?



src/apps/marble-kde/marble_part.cpp
<http://git.reviewboard.kde.org/r/114089/#comment31751>

    "You again" -> "You still"
    "If you didn't see KWallet dialog" -> "If you haven't seen the KWallet dialog".
    
    "it means that you deny it forever" ->
    "it means that you have disabled it.".


- Torsten Rahn


On Nov. 25, 2013, 12:49 p.m., Egor Matirov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114089/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2013, 12:49 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> kwallet support for owncloud sync. GCI task: https://www.google-melange.com/gci/task/view/google/gci2013/5279620895080448
> 
> 
> Diffs
> -----
> 
>   src/apps/marble-kde/marble.kcfg dd6b199 
>   src/apps/marble-kde/marble_part.h ddb91ea 
>   src/apps/marble-kde/marble_part.cpp 082ad5e 
> 
> Diff: http://git.reviewboard.kde.org/r/114089/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Egor Matirov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131125/10897d32/attachment.html>