[Marble-devel] Review Request 114082: Added combobox support to the Marble Legend Browser

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114082/#review44362
-----------------------------------------------------------



src/lib/marble/MarbleLegendBrowser.cpp
<http://git.reviewboard.kde.org/r/114082/#comment31723>

    You don't need to initialize QStrings as empty ""
    Just
    QString comboBoxString is enough.



src/lib/marble/MarbleLegendBrowser.cpp
<http://git.reviewboard.kde.org/r/114082/#comment31724>

    same, please correct.



src/lib/marble/MarbleLegendBrowser.cpp
<http://git.reviewboard.kde.org/r/114082/#comment31725>

    improper spacing. Please use
    
    int comboCount = 0;



src/lib/marble/MarbleLegendBrowser.cpp
<http://git.reviewboard.kde.org/r/114082/#comment31737>

    spacing ...



src/lib/marble/MarbleLegendBrowser.cpp
<http://git.reviewboard.kde.org/r/114082/#comment31738>

    spacing



src/lib/marble/MarbleLegendBrowser.cpp
<http://git.reviewboard.kde.org/r/114082/#comment31726>

    please add spaces
    comboBoxString += " .....



src/lib/marble/MarbleLegendBrowser.cpp
<http://git.reviewboard.kde.org/r/114082/#comment31727>

    see above



src/lib/marble/MarbleLegendBrowser.cpp
<http://git.reviewboard.kde.org/r/114082/#comment31728>

    see above.



src/lib/marble/MarbleLegendBrowser.cpp
<http://git.reviewboard.kde.org/r/114082/#comment31729>

    we prefer preincrement over postincrement whereever possible:
    
    ++comboCount;



src/lib/marble/MarbleLegendBrowser.cpp
<http://git.reviewboard.kde.org/r/114082/#comment31730>

    section->radio().isEmpty()



src/lib/marble/MarbleLegendBrowser.cpp
<http://git.reviewboard.kde.org/r/114082/#comment31732>

    QString currentConnect;



src/lib/marble/MarbleLegendBrowser.cpp
<http://git.reviewboard.kde.org/r/114082/#comment31731>

    spacing ...



src/lib/marble/MarbleLegendBrowser.cpp
<http://git.reviewboard.kde.org/r/114082/#comment31733>

    spacing ...



src/lib/marble/geodata/handlers/dgml/DgmlAttributeDictionary.cpp
<http://git.reviewboard.kde.org/r/114082/#comment31734>

    please adjust the spacing to match the others.



src/lib/marble/geodata/scene/GeoSceneSection.h
<http://git.reviewboard.kde.org/r/114082/#comment31735>

    superfluous tab



src/lib/marble/geodata/scene/GeoSceneSection.h
<http://git.reviewboard.kde.org/r/114082/#comment31736>

    please adjust the indentation to match the other lines.


- Torsten Rahn


On Nov. 24, 2013, 3:41 p.m., Yazeed Zoabi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114082/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2013, 3:41 p.m.)
> 
> 
> Review request for Marble, Utku Aydın, Dennis Nienhüser, and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> You can now use add comboboxes in maps.
> 
> In order to use this feature, new attributes to sections are introduced: combobox, comboboxOrder.
> the comboboxOrder attribute should appear twice, once to indicate that top of a combobox, and the other to indicate it's bottom :D. (top: "first", middle: [anything but first or last], bottom: "last")
> 
> note: You must keep checkable="true" (one reason for that is for options to function as checkboxes in older versions of marble)
> 
> Example:
> 
> 	      <section name="first" checkable="true" combobox="true" comboboxOrder="first" connect="first" spacing="12">
> 		  <heading>First option</heading>
> 	      </section>
> 	      <section name="middle" checkable="true" combobox="true" comboboxOrder="" connect="middle" spacing="12">
> 		  <heading>Middle option</heading>
> 	      </section>
> 	      <section name="last" checkable="true" combobox="true" comboboxOrder="last" connect="last" spacing="12">
> 		  <heading>Last option</heading>
> 	      </section>
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/MarbleLegendBrowser.h e7fb4b5 
>   src/lib/marble/MarbleLegendBrowser.cpp 644dd0f 
>   src/lib/marble/geodata/handlers/DgmlOptionTagHandler.h e69de29 
>   src/lib/marble/geodata/handlers/DgmlOptionTagHandler.cpp e69de29 
>   src/lib/marble/geodata/handlers/dgml/DgmlAttributeDictionary.h d426e0d 
>   src/lib/marble/geodata/handlers/dgml/DgmlAttributeDictionary.cpp 20b0ebe 
>   src/lib/marble/geodata/handlers/dgml/DgmlSectionTagHandler.cpp 66ee562 
>   src/lib/marble/geodata/parser/GeoSceneTypes.h 5fd1cdb 
>   src/lib/marble/geodata/parser/GeoSceneTypes.cpp a653d02 
>   src/lib/marble/geodata/scene/GeoSceneOption.h e69de29 
>   src/lib/marble/geodata/scene/GeoSceneOption.cpp e69de29 
>   src/lib/marble/geodata/scene/GeoSceneSection.h 5224f43 
>   src/lib/marble/geodata/scene/GeoSceneSection.cpp 9d7bf77 
> 
> Diff: http://git.reviewboard.kde.org/r/114082/diff/
> 
> 
> Testing
> -------
> 
> Kubuntu 13.10 . Qt version:  4.8.4 .
> 
> 
> Thanks,
> 
> Yazeed Zoabi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131124/e2c050ef/attachment-0001.html>