[Marble-devel] Review Request 114054: Install a .desktop file for each Marble variant (Qt, Mobile, KDE)

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114054/#review44260
-----------------------------------------------------------

Ship it!


Makes sense to rely on packagers IMHO. They should also take care to select which of the binaries are installed.



src/apps/marble-mobile/marble-mobile.desktop
<http://git.reviewboard.kde.org/r/114054/#comment31686>

    I'd remove that line since our handbook does not cover the mobile applications
    See also https://bugs.kde.org/show_bug.cgi?id=327937


- Dennis Nienhüser


On Nov. 23, 2013, 2:13 p.m., Bernhard Beschow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114054/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2013, 2:13 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Bugs: 327405
>     http://bugs.kde.org/show_bug.cgi?id=327405
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Due to string freeze in the 4.12 branch all three .desktop files have the same user-visible strings which may confuse users. We may need to rely on packagers to install only the required .desktop files.
> 
> See also note below.
> 
> 
> Diffs
> -----
> 
>   src/apps/marble-mobile/CMakeLists.txt f02c5fc2bb397a7f0cc20e202cc403a4edc27c17 
>   src/apps/marble-mobile/marble-mobile.desktop PRE-CREATION 
>   src/apps/marble-qt/CMakeLists.txt 58425d5f7e823660fc13156d6b19f1b35b4f17ae 
>   src/apps/marble-qt/marble-qt.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/114054/diff/
> 
> 
> Testing
> -------
> 
> KRunner now lists "Marble Virtual Globe" three times. They'll start different variants of Marble but the entries are indistinguishable.
> 
> 
> Thanks,
> 
> Bernhard Beschow
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131123/ed827495/attachment.html>