[Marble-devel] Review Request 114031: Added Radio buttons support for the Marble Legend Browser

[Yazeed Zoabi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114031/
-----------------------------------------------------------

(Updated Nov. 23, 2013, 1:19 p.m.)


Status
------

This change has been marked as submitted.


Review request for Marble, Utku Aydın, Dennis Nienhüser, and Torsten Rahn.


Repository: marble


Description
-------

What has basically changed, is that Radio buttons are now implemented in the Marble Legend browser.. you can now add sections (in dgml files) with an Multiple radio buttons (a group of radio buttons) must have the same value for the radio attribute to indicate the group. (a special value for each group) .

Example of sections that are now shown as radio buttons :
        <section name="riciolli" radio="RH" checkable="true" connect="riciolli" spacing="12">
                  <heading><![CDATA[<a href="http://en.wikipedia.org/wiki/Giambattista_Riccioli">Riciolli</a>]]></heading>
              </section>
              <section name="hevelius" radio="RH" checkable="true" connect="hevelius" spacing="12">
                  <heading><![CDATA[<a href="http://en.wikipedia.org/wiki/Johannes_Hevelius">Hevelius</a>]]></heading>
              </section>


Diffs
-----

  src/lib/marble/MarbleLegendBrowser.h c2a8c62 
  src/lib/marble/MarbleLegendBrowser.cpp 53524a4 
  src/lib/marble/geodata/handlers/dgml/DgmlAttributeDictionary.h 2785289 
  src/lib/marble/geodata/handlers/dgml/DgmlAttributeDictionary.cpp 6940d62 
  src/lib/marble/geodata/handlers/dgml/DgmlSectionTagHandler.cpp 82aadc9 
  src/lib/marble/geodata/scene/GeoSceneSection.h 7e60c3c 
  src/lib/marble/geodata/scene/GeoSceneSection.cpp 8268530 

Diff: http://git.reviewboard.kde.org/r/114031/diff/


Testing
-------

Testing was done on Kubuntu 13.10 .

tested the same dgml file with an older marble version (with no radio button implementation), and works fine with checkboxes.


Thanks,

Yazeed Zoabi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131123/2b11c8e7/attachment.html>