[Marble-devel] Review Request 114051: Generate translation files for the Qt version automatically, if any

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114051/#review44257
-----------------------------------------------------------


This review has been submitted with commit e4fae1a58e46d174fbc26d55299511eda97d75d0 by Bernhard Beschow to branch KDE/4.12.

- Commit Hook


On Nov. 23, 2013, 12:47 p.m., Bernhard Beschow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114051/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2013, 12:47 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> If translation files in .po format are present in ${src}/data/lang, .qm files will be generated automatically in the build directory, ready for installation during "make install". The .po files can be downloaded by running the script "download-translations.bash" which also resides in ${src}/data/lang.
> 
> The motivation for this change is to simplify packaging for the Maemo5 version where the build system had to be patched for installation of translations.
> 
> Note that I'd like to backport this patch to Marble 1.7 (KDE 4.12). Any objections?
> 
> 
> Diffs
> -----
> 
>   data/CMakeLists.txt 22f55772a8dcf46bc91ad66f921f1ccf4b03033f 
>   data/lang/.gitignore PRE-CREATION 
>   data/lang/CMakeLists.txt PRE-CREATION 
>   data/lang/download-translations.bash PRE-CREATION 
>   tools/CMakeLists.txt f3bd4b709c6828634411e63adeca4bbcdf57019d 
>   tools/translations/CMakeLists.txt 3d1f6af7b8a04ef3f214df9fe3e5298bd5cf24cd 
>   tools/translations/marble_i18n.sh  
>   tools/translations/marble_qt_i18n.bash 5395703d79773765efaeece9f0422639f2952317 
>   tools/translations/merge_ts_po.cpp  
>   tools/translations/routing-instructions_i18n.bash  
> 
> Diff: http://git.reviewboard.kde.org/r/114051/diff/
> 
> 
> Testing
> -------
> 
> Tested only with Qt 4. Any volunteers for Qt 5?
> 
> All .po files were converted such that the Qt version of Marble recognized the translations under Arch Linux and Maemo5.
> 
> 
> Thanks,
> 
> Bernhard Beschow
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131123/b11e0eb9/attachment-0001.html>