[Marble-devel] Review Request 113928: Support for writing the KML gx:TimeStamp/gx:TimeSpan tags

[Illya Kovalevskyy]

> On Nov. 19, 2013, 12:20 p.m., Dennis Nienhüser wrote:
> > src/lib/marble/geodata/writers/kml/KmlLookAtTagWriter.cpp, line 35
> > <http://git.reviewboard.kde.org/r/113928/diff/2/?file=214813#file214813line35>
> >
> >     Can you introduce a static method somewhere to avoid the code duplication? We could also refactor the "normal" time primitive writers to reuse it later on (the current time span writer is wrong wrt unbounded time spans as well).
> >

I thought about it but then understood that this is not so necassary. This kind of little code duplication is better than overweighting oher non-related blocks


> On Nov. 19, 2013, 12:20 p.m., Dennis Nienhüser wrote:
> > src/lib/marble/geodata/writers/kml/KmlCameraTagWriter.cpp, line 40
> > <http://git.reviewboard.kde.org/r/113928/diff/2/?file=214812#file214812line40>
> >
> >     Only write begin if it is valid (see above) to respect unbounded time spans

Aha...


- Illya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113928/#review43928
-----------------------------------------------------------


On Nov. 19, 2013, 12:19 a.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113928/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2013, 12:19 a.m.)
> 
> 
> Review request for Marble and Dennis Nienhüser.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> According to Google Code-In 2013 task (http://www.google-melange.com/gci/task/view/google/gci2013/5869627129200640)
> 
> KmlCameraTagWriter and KmlLookAtTagWriter (in src/lib/marble/geodata/writers/kml/) have been extended to support writing their time primitives (time span and time stamp) in gx:TimeStamp and gx:TimeSpan tags.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/geodata/writers/kml/KmlCameraTagWriter.cpp a91f2cc 
>   src/lib/marble/geodata/writers/kml/KmlLookAtTagWriter.cpp fc5d617 
> 
> Diff: http://git.reviewboard.kde.org/r/113928/diff/
> 
> 
> Testing
> -------
> 
> It's not breaking anything, I promise :)
> 
> Compiled & run on Kubuntu Linux
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131119/1659adf9/attachment.html>