[Marble-devel] Review Request 113776: SoCIS 2013 - eclipse branch rebasing

[Marek Hakala]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113776/
-----------------------------------------------------------

Review request for Marble, Torsten Rahn and René Küttner.


Repository: marble


Description
-------

Solving the conflicts #1


EclipsesPlugin: Update EclSolar

This update fixes some issues with very short eclipse events.

EclipsesPlugin: Update eclipses menu on config changes


EclipsesPlugin: Enable lunar eclipses


EclipsesPlugin: Fix timezone handling


EclipsesPlugin: Fix dates for very short eclipses


EclipsesPlugin: Allow for year 0


EclipsesPlugin: Move close button to the bottom left


EclipsesPlugin: Adjust eclipse browser dialog


Normalize all coordinates involved so that everything shows up nicely in flat maps as well


Just render GeoDataLinearRings. Mute colors to something decent.


EclipsesPlugin: Allow for years B.C.


EclipsesPlugin: Do consistent variable naming


EclipsesPlugin: Fix calculation of sunset/sunrise boundaries


EclipsesPlugin: Remove deprecated method declaration


EclipsesPlugin: Do not set brush in every loop cycle


EclipsesPlugin: Do not plot central line for non-central eclipses


EclipsesPlugin: Minor code cleanup


EclipsesPlugin: EclipsesListDialog -> EclipsesBrowserDialog


EclipsesPlugin: Document methods


EclipsesPlugin: Connect plugin menu handler only once


EclipsesPlugin: Add menu separator in kde version


EclipsesPlugin: Set icons for menu items


EclipsesPlugin: Add new icons


EclipsesPlugin: Add 'Apply' button to configuration dialog


EclipsesPlugin: Implement reading and writing of settings


EclipsesPlugin: Jump to eclipse's maximum


EclipsesPlugin: Improve eclipses list dialog


EclipsesPlugin: "More Eclipses" -> "Browse Eclipses"


EclipsesPlugin: Redesign config dialog


EclipsesPlugin: Fix eclipse menu updates


EclipsesPlugin: Calculate eclipse's global start and end dates


EclipsesPlugin: Make eclipse menu items work


EclipsesPlugin: Disable epxansion of tree view on double click


EclipsesPlugin: Make list dialog work


EclipsesPlugin: Add new eclipses list dialog


EclipsesPlugin: Always reference an eclipse by year and index


EclipsesPlugin: Return references


EclipsesPlugin: Fix memory leak


EclipsesPlugin: Move render code out of model


EclipsesPlugin: Enable configuration dialog


EclipsesPlugin: Make text for maximum translatable


EclipsesPlugin: Move calculation out of paint routine


EclipsesPlugin: Add plugin icon


EclipsesPlugin: Do not stop marble clock when viewing eclipse


EclipsesPlugin: Make menu items and dialogs work


EclipsesPlugin: add initial ui files


EclipsesPlugin: move paint routine to model


EclipsesPlugin: add model and item classes


EclipsesPlugin: add sekeleton for upcoming eclipses plugin


Diffs
-----

  src/apps/marble-kde/marble_part.cpp 98092a8 
  src/apps/marble-kde/marble_part.rc baa3618 
  src/apps/marble-qt/QtMainWindow.h 80ae250 
  src/apps/marble-qt/QtMainWindow.cpp 5615f65 
  src/lib/marble/RenderPlugin.cpp a51b27f 
  src/plugins/render/CMakeLists.txt c62070f 
  src/plugins/render/eclipses/CMakeLists.txt PRE-CREATION 
  src/plugins/render/eclipses/EclipsesBrowserDialog.h PRE-CREATION 
  src/plugins/render/eclipses/EclipsesBrowserDialog.cpp PRE-CREATION 
  src/plugins/render/eclipses/EclipsesBrowserDialog.ui PRE-CREATION 
  src/plugins/render/eclipses/EclipsesConfigDialog.ui PRE-CREATION 
  src/plugins/render/eclipses/EclipsesItem.h PRE-CREATION 
  src/plugins/render/eclipses/EclipsesItem.cpp PRE-CREATION 
  src/plugins/render/eclipses/EclipsesModel.h PRE-CREATION 
  src/plugins/render/eclipses/EclipsesModel.cpp PRE-CREATION 
  src/plugins/render/eclipses/EclipsesPlugin.h PRE-CREATION 
  src/plugins/render/eclipses/EclipsesPlugin.cpp PRE-CREATION 
  src/plugins/render/eclipses/EclipsesReminderDialog.ui PRE-CREATION 
  src/plugins/render/eclipses/ecl/README PRE-CREATION 
  src/plugins/render/eclipses/ecl/astrolib.h PRE-CREATION 
  src/plugins/render/eclipses/ecl/astrolib.cpp PRE-CREATION 
  src/plugins/render/eclipses/ecl/attlib.h PRE-CREATION 
  src/plugins/render/eclipses/ecl/attlib.cpp PRE-CREATION 
  src/plugins/render/eclipses/ecl/eclsolar.h PRE-CREATION 
  src/plugins/render/eclipses/ecl/eclsolar.cpp PRE-CREATION 
  src/plugins/render/eclipses/eclipses.qrc PRE-CREATION 
  src/plugins/render/eclipses/res/eclipses.png PRE-CREATION 
  src/plugins/render/eclipses/res/lunar_partial.png PRE-CREATION 
  src/plugins/render/eclipses/res/lunar_penumbra.png PRE-CREATION 
  src/plugins/render/eclipses/res/lunar_total.png PRE-CREATION 
  src/plugins/render/eclipses/res/solar_annular.png PRE-CREATION 
  src/plugins/render/eclipses/res/solar_partial.png PRE-CREATION 
  src/plugins/render/eclipses/res/solar_total.png PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/113776/diff/


Testing
-------


Thanks,

Marek Hakala

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131109/e462c683/attachment.html>