[Marble-devel] Review Request 110677: Fix comparison with uninitialized variable

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110677/
-----------------------------------------------------------

(Updated May 30, 2013, 7:57 a.m.)


Status
------

This change has been marked as submitted.


Review request for Marble and Dennis Nienhüser.


Description
-------

We were checking the uninitialized member "m_dimension"
in setDimenson() if it already contained the same value.

Remove this optimization as it's not really needed.

valgrind complained:
==27427== Conditional jump or move depends on uninitialised value(s)
==27427==    at 0x72A9141: Marble::LatLonEdit::setDimension(Marble::Dimension) (LatLonEdit.cpp:520)
==27427==    by 0x72A95B8: Marble::LatLonEdit::LatLonEdit(QWidget*, Marble::Dimension, Marble::GeoDataCoordina

==27427==    by 0x72FC7F6: Ui_UiEditBookmarkDialog::setupUi(QDialog*) (ui_EditBookmarkDialog.h:83)

==27427==    by 0x72FC22A: Marble::EditBookmarkDialogPrivate::initialize() (EditBookmarkDialog.cpp:68)
==27427==    by 0x72FC3C9: Marble::EditBookmarkDialog::EditBookmarkDialog(Marble::BookmarkManager*, QWidget*)

==27427==    by 0x4254E0: Marble::MainWindow::openEditBookmarkDialog() (QtMainWindow.cpp:551)
==27427==    by 0x4FBDC8E: QMetaObject::activate(QObject*, QMetaObject const*, int, void**) (in /usr/lib64/lib
==27427==    by 0x57463F1: QAction::triggered(bool) (in /usr/lib64/libQtGui.so.4.8.4)
==27427==    by 0x57465DF: QAction::activate(QAction::ActionEvent) (in /usr/lib64/libQtGui.so.4.8.4)
==27427==    by 0x5B7FD92: ??? (in /usr/lib64/libQtGui.so.4.8.4)
==27427==    by 0x5B86178: ??? (in /usr/lib64/libQtGui.so.4.8.4)
==27427==    by 0x579BF28: QWidget::event(QEvent*) (in /usr/lib64/libQtGui.so.4.8.4)


Diffs
-----

  src/lib/LatLonEdit.cpp bdbc366 

Diff: http://git.reviewboard.kde.org/r/110677/diff/


Testing
-------


Thanks,

Thomas Jarosch

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130530/5ad8739f/attachment-0001.html>