[Marble-devel] Review Request 110714: Fix clearing of current route segment list

Dennis Nienhüser earthwings at gentoo.org
Thu May 30 07:57:00 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110714/#review33402
-----------------------------------------------------------

Ship it!


Ship It!

- Dennis Nienhüser


On May 29, 2013, 6:33 p.m., Thomas Jarosch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110714/
> -----------------------------------------------------------
> 
> (Updated May 29, 2013, 6:33 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Fix clearing of current route segment list,
> 
> we were calling container.empty() instead of container.clear().
> 
> cppcheck reported:
> [src/plugins/render/elevationprofilefloatitem/ElevationProfileFloatItem.cpp:558]: (warning) Ineffective call of function 'empty()'. Did you intend to call 'clear()' instead?
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/elevationprofilefloatitem/ElevationProfileFloatItem.cpp 0cbf307 
> 
> Diff: http://git.reviewboard.kde.org/r/110714/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thomas Jarosch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130530/8361b6ed/attachment-0001.html>


More information about the Marble-devel mailing list