[Marble-devel] Review Request 110637: gx:Tour KML Tag Writer

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110637/#review33107
-----------------------------------------------------------



src/lib/geodata/writers/kml/KmlPlaylistTagWriter.cpp
<http://git.reviewboard.kde.org/r/110637/#comment24491>

    Since the tour primitives are not shared with other features I'd write them here directly (or better yet in new methods of this writer). We have GeoData* classes for FlyTo (needs to be fixed to become a TourPrimitive as you said) and TourControl already, so they could be written here. So I'd change that line to
    
    writeTourPrimitive( &playlist->primitive( i ), writer );
    
    and implement it like
    void writeTourPrimitive(...)
    {
      if ( primitive->nodeType() == GeoDataTypes::GeoDataTourControl ) {
        writeTourControl( static_cast<GeoDataTourControl>( primitive );
      } else if ...
    }
    
    and
    void writeTourControl(...)
    {
      ...
    }
    
    void writeFlyTo(...)
    {
      ...
    }
    



src/lib/geodata/writers/kml/KmlTourTagWriter.cpp
<http://git.reviewboard.kde.org/r/110637/#comment24490>

    The id, name and description of the tour should be written as well (if they are defined). See https://developers.google.com/kml/documentation/kmlreference?hl=de#gxtour


- Dennis Nienhüser


On May 24, 2013, 6:08 p.m., Adrian Draghici wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110637/
> -----------------------------------------------------------
> 
> (Updated May 24, 2013, 6:08 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Adds support for writing the gx:Tour KML element and its child elements for which the corresponding GeoDataType is already defined.
> 
> 
> Diffs
> -----
> 
>   src/lib/geodata/parser/GeoDataTypes.h c74b3bf 
>   src/lib/geodata/parser/GeoDataTypes.cpp 35cecbd 
>   src/lib/geodata/writers/KmlTourTagWriter.h e69de29 
>   src/lib/geodata/writers/KmlTourTagWriter.cpp e69de29 
>   src/lib/geodata/writers/kml/KmlPlaylistTagWriter.h e69de29 
>   src/lib/geodata/writers/kml/KmlPlaylistTagWriter.cpp e69de29 
>   src/lib/geodata/writers/kml/KmlTourTagWriter.h e69de29 
>   src/lib/geodata/writers/kml/KmlTourTagWriter.cpp e69de29 
> 
> Diff: http://git.reviewboard.kde.org/r/110637/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Adrian Draghici
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130524/898b27f2/attachment.html>