[Marble-devel] Review Request 109379: ElevationProfile: support for gpx-tracks

[Roman Karlstetter]

> On May 21, 2013, 5:13 a.m., Dennis Nienhüser wrote:
> > Can you please add it to http://techbase.kde.org/Schedules/KDE4/4.11_Feature_Plan so that we get two more weeks to commit it? Otherwise tomorrow would be the deadline for 1.6.

done


- Roman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109379/#review32859
-----------------------------------------------------------


On May 20, 2013, 8:24 p.m., Roman Karlstetter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109379/
> -----------------------------------------------------------
> 
> (Updated May 20, 2013, 8:24 p.m.)
> 
> 
> Review request for Marble and Bernhard Beschow.
> 
> 
> Description
> -------
> 
> Changes to the elevation profile plugin, it's now possible to display the height profile for a GPX-track opened from file.
> 
> I made a new classes for
> a) providing the data, one for routes and one for tracks. They are in the same file, should this be split into multiple files?
> b) the contextmenu, because it has some members which would only clutter ElevationProfileFloatItem. It is a friend class, is this ok?
> 
> Comments please :) 
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/elevationprofilefloatitem/CMakeLists.txt 872e5e1 
>   src/plugins/render/elevationprofilefloatitem/ElevationProfileContextMenu.h PRE-CREATION 
>   src/plugins/render/elevationprofilefloatitem/ElevationProfileContextMenu.cpp PRE-CREATION 
>   src/plugins/render/elevationprofilefloatitem/ElevationProfileDataSource.h PRE-CREATION 
>   src/plugins/render/elevationprofilefloatitem/ElevationProfileDataSource.cpp PRE-CREATION 
>   src/plugins/render/elevationprofilefloatitem/ElevationProfileFloatItem.h cb3bff1 
>   src/plugins/render/elevationprofilefloatitem/ElevationProfileFloatItem.cpp 0cbf307 
>   src/plugins/render/elevationprofilefloatitem/ElevationProfileRouteDataSource.h PRE-CREATION 
>   src/plugins/render/elevationprofilefloatitem/ElevationProfileRouteDataSource.cpp PRE-CREATION 
>   src/plugins/render/elevationprofilefloatitem/ElevationProfileTrackDataSource.h PRE-CREATION 
>   src/plugins/render/elevationprofilefloatitem/ElevationProfileTrackDataSource.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109379/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Roman Karlstetter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130521/b47507a8/attachment.html>