[Marble-devel] Review Request 109379: ElevationProfile: support for gpx-tracks

[Roman Karlstetter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109379/
-----------------------------------------------------------

(Updated May 20, 2013, 8:24 p.m.)


Review request for Marble and Bernhard Beschow.


Changes
-------

updated diff.

For every loaded file, there is now one entry in the menu. This entry shows height data for all tracks in the file joined together to one track. And I fixed all the things that were mentioned in the comments.


Description
-------

Changes to the elevation profile plugin, it's now possible to display the height profile for a GPX-track opened from file.

I made a new classes for
a) providing the data, one for routes and one for tracks. They are in the same file, should this be split into multiple files?
b) the contextmenu, because it has some members which would only clutter ElevationProfileFloatItem. It is a friend class, is this ok?

Comments please :) 


Diffs (updated)
-----

  src/plugins/render/elevationprofilefloatitem/CMakeLists.txt 872e5e1 
  src/plugins/render/elevationprofilefloatitem/ElevationProfileContextMenu.h PRE-CREATION 
  src/plugins/render/elevationprofilefloatitem/ElevationProfileContextMenu.cpp PRE-CREATION 
  src/plugins/render/elevationprofilefloatitem/ElevationProfileDataSource.h PRE-CREATION 
  src/plugins/render/elevationprofilefloatitem/ElevationProfileDataSource.cpp PRE-CREATION 
  src/plugins/render/elevationprofilefloatitem/ElevationProfileFloatItem.h cb3bff1 
  src/plugins/render/elevationprofilefloatitem/ElevationProfileFloatItem.cpp 0cbf307 
  src/plugins/render/elevationprofilefloatitem/ElevationProfileRouteDataSource.h PRE-CREATION 
  src/plugins/render/elevationprofilefloatitem/ElevationProfileRouteDataSource.cpp PRE-CREATION 
  src/plugins/render/elevationprofilefloatitem/ElevationProfileTrackDataSource.h PRE-CREATION 
  src/plugins/render/elevationprofilefloatitem/ElevationProfileTrackDataSource.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/109379/diff/


Testing
-------


Thanks,

Roman Karlstetter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130520/3f957004/attachment.html>