[Marble-devel] Review Request 110403: Add support for reading the KML Model tag

Dennis Nienhüser earthwings at gentoo.org
Wed May 15 17:53:25 UTC 2013 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110403/#review32587
-----------------------------------------------------------


Great, nearly done now :)


src/lib/geodata/data/GeoDataLink.cpp
<http://git.reviewboard.kde.org/r/110403/#comment24248>

    Copyright year missing



src/lib/geodata/data/GeoDataLocation.h
<http://git.reviewboard.kde.org/r/110403/#comment24249>

    Please use doxygen comment tags above the method, only those show up in API docs.
    
    /** Returns the distance to earth's surface in meters, interpreted according to altitudeMode */
    qreal altitude() const;
    



src/lib/geodata/data/GeoDataModel.cpp
<http://git.reviewboard.kde.org/r/110403/#comment24250>

    For consistency please also initialize m_orientation, m_location and m_targetHref



src/lib/geodata/data/GeoDataOrientation.h
<http://git.reviewboard.kde.org/r/110403/#comment24253>

    A doxygen comment for this one would be nice as well.
    



src/lib/geodata/data/GeoDataOrientation.h
<http://git.reviewboard.kde.org/r/110403/#comment24251>

    Please move the comment above the method and start it with two stars, i.e. /** Rotation...
    
    For copyright reasons I'd rather not have copy-and-paste comments of the kml reference here, please describe in your own words.



src/lib/geodata/data/GeoDataOrientation.h
<http://git.reviewboard.kde.org/r/110403/#comment24252>

    Same as with tilt



src/lib/geodata/handlers/kml/KmlAltitudeTagHandler.h
<http://git.reviewboard.kde.org/r/110403/#comment24254>

    Please remove



src/lib/geodata/handlers/kml/KmlLatitudeTagHandler.h
<http://git.reviewboard.kde.org/r/110403/#comment24255>

    Remove



src/lib/geodata/handlers/kml/KmlRefreshModeTagHandler.cpp
<http://git.reviewboard.kde.org/r/110403/#comment24257>

    Please use 
    mDebug() << "Value" << content << "set in" ...
    
    People love useful warnings.
    



src/lib/geodata/parser/GeoDataTypes.cpp
<http://git.reviewboard.kde.org/r/110403/#comment24260>

    Good catch :-)


- Dennis Nienhüser


On May 15, 2013, 3:43 p.m., Sanjiban Bairagya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110403/
> -----------------------------------------------------------
> 
> (Updated May 15, 2013, 3:43 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Previously there was no way to read the <Model> tag in the kml files, if any. I added a few GeoData classes and tag-handlers which makes it possible now.
> 
> 
> This addresses bug 318288.
>     http://bugs.kde.org/show_bug.cgi?id=318288
> 
> 
> Diffs
> -----
> 
>   src/lib/geodata/CMakeLists.txt 1644d87 
>   src/lib/geodata/data/GeoDataAlias.h PRE-CREATION 
>   src/lib/geodata/data/GeoDataAlias.cpp PRE-CREATION 
>   src/lib/geodata/data/GeoDataGeometry.h 19cdd29 
>   src/lib/geodata/data/GeoDataLink.h 6cba0da 
>   src/lib/geodata/data/GeoDataLink.cpp 2c8f08b 
>   src/lib/geodata/data/GeoDataLocation.h PRE-CREATION 
>   src/lib/geodata/data/GeoDataLocation.cpp PRE-CREATION 
>   src/lib/geodata/data/GeoDataModel.h PRE-CREATION 
>   src/lib/geodata/data/GeoDataModel.cpp PRE-CREATION 
>   src/lib/geodata/data/GeoDataOrientation.h PRE-CREATION 
>   src/lib/geodata/data/GeoDataOrientation.cpp PRE-CREATION 
>   src/lib/geodata/data/GeoDataResourceMap.h PRE-CREATION 
>   src/lib/geodata/data/GeoDataResourceMap.cpp PRE-CREATION 
>   src/lib/geodata/data/GeoDataScale.h PRE-CREATION 
>   src/lib/geodata/data/GeoDataScale.cpp PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlAliasTagHandler.h PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlAliasTagHandler.cpp PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlAltitudeModeTagHandler.cpp 827293b 
>   src/lib/geodata/handlers/kml/KmlAltitudeTagHandler.h e34fd61 
>   src/lib/geodata/handlers/kml/KmlAltitudeTagHandler.cpp 6884dba 
>   src/lib/geodata/handlers/kml/KmlCoordinatesTagHandler.cpp 1d479fe 
>   src/lib/geodata/handlers/kml/KmlElementDictionary.h 11d9f1d 
>   src/lib/geodata/handlers/kml/KmlElementDictionary.cpp 36a1b0e 
>   src/lib/geodata/handlers/kml/KmlHeadingTagHandler.cpp a0c4801 
>   src/lib/geodata/handlers/kml/KmlHrefTagHandler.cpp 052d5b0 
>   src/lib/geodata/handlers/kml/KmlLatitudeTagHandler.h c11ca2b 
>   src/lib/geodata/handlers/kml/KmlLatitudeTagHandler.cpp 8040b97 
>   src/lib/geodata/handlers/kml/KmlLinkTagHandler.h 414face 
>   src/lib/geodata/handlers/kml/KmlLinkTagHandler.cpp a23acda 
>   src/lib/geodata/handlers/kml/KmlLocationTagHandler.h PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlLocationTagHandler.cpp PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlLongitudeTagHandler.h e8e81e4 
>   src/lib/geodata/handlers/kml/KmlLongitudeTagHandler.cpp 88f534b 
>   src/lib/geodata/handlers/kml/KmlModelTagHandler.h PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlModelTagHandler.cpp PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlOrientationTagHandler.h PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlOrientationTagHandler.cpp PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlRefreshModeTagHandler.cpp 21447fe 
>   src/lib/geodata/handlers/kml/KmlResourceMapTagHandler.h PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlResourceMapTagHandler.cpp PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlRollTagHandler.h 7aa69f3 
>   src/lib/geodata/handlers/kml/KmlRollTagHandler.cpp 22404bf 
>   src/lib/geodata/handlers/kml/KmlScaleTagHandler.h PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlScaleTagHandler.cpp PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlSourceHrefTagHandler.h PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlSourceHrefTagHandler.cpp PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlTargetHrefTagHandler.h PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlTargetHrefTagHandler.cpp PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlTiltTagHandler.cpp 806593c 
>   src/lib/geodata/handlers/kml/KmlXTagHandler.h PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlXTagHandler.cpp PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlYTagHandler.h PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlYTagHandler.cpp PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlZTagHandler.h PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlZTagHandler.cpp PRE-CREATION 
>   src/lib/geodata/parser/GeoDataTypes.h 1bc7828 
>   src/lib/geodata/parser/GeoDataTypes.cpp ec7c414 
>   src/lib/geodata/parser/GeoDocument.cpp ee6834a 
>   tests/CMakeLists.txt d4cfec5 
>   tests/TestModel.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/110403/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sanjiban Bairagya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130515/5108c15c/attachment-0001.html>

More information about the Marble-devel mailing list