[Marble-devel] Review Request 110058: Spherical Projection Panning

[Paul Nader]

> On April 28, 2013, 8:53 a.m., Dennis Nienhüser wrote:
> > Hi Paul, thanks for the awesome patch! Quite impressive that you're able to implement this rather massive change (it removes one of the fundamental assumptions) with a reasonable small amount of code.
> > 
> > What I'd like to have is some timing measurements to ensure we're not losing rendering performance when no panning is in effect. Getting Bernhard's thoughts on the rendering part would be great.
> > 
> > I was wondering about the stars plugin -- it does not change its rendering when panning is applied, but I think it needs to take that into account. Torsten, can you have a look at that?
> > 
> > Some nitpicking on code style and API below.

Hi Dennis & thanks for the detailed review.

r6 should now give acceptable fps rates when rotating and when panning.

Also you state correctly that the stars should move but I think this is more as a result of the fact the earth rotation has to be adjusted to take into account the change of viewpoint. Doing so now during panning causes the right effect I think. Changing the stars plugin I think is
not correct.


> On April 28, 2013, 8:53 a.m., Dennis Nienhüser wrote:
> > src/lib/MarbleWidgetInputHandler.cpp, line 684
> > <http://git.reviewboard.kde.org/r/110058/diff/5/?file=139644#file139644line684>
> >
> >     there's also an in-place translate() method, i.e. 
> >     
> >     boundingRect.translate( MarbleWidgetInputHandler::d->m_widget->pan() )

thanks


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110058/#review31691
-----------------------------------------------------------


On May 15, 2013, 12:12 a.m., Paul Nader wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110058/
> -----------------------------------------------------------
> 
> (Updated May 15, 2013, 12:12 a.m.)
> 
> 
> Review request for Marble, Bernhard Beschow and Dennis Nienhüser.
> 
> 
> Description
> -------
> 
> Translates the scene viewpoint in a plane orthogonal to the line of sight of the viewer.
> 
> Version    Changes
> -------+-----------------------------------------------------------------
>    r6      Routing Layer now working :)
>            Reverted back to rendering while panning
>            Better overall FPS rate
>            Globe rotation adjusted while panning
>            Support for panning using keyboard and arrow disk widget arrows.
>            Bugfixes: https://github.com/oberluz/marble
> 
> 
> Diffs
> -----
> 
>   src/QtMainWindow.cpp 50a4676 
>   src/lib/AbstractDataPlugin.cpp 347f4b1 
>   src/lib/GoToDialog.cpp 57b65de 
>   src/lib/LayerInterface.h 46a20da 
>   src/lib/LayerInterface.cpp c3629de 
>   src/lib/LayerManager.cpp 0df19d2 
>   src/lib/MapInfoDialog.cpp 5219983 
>   src/lib/MarbleModel.h 44a5f61 
>   src/lib/MarbleModel.cpp a84ccae 
>   src/lib/MarbleWidget.h 9203250 
>   src/lib/MarbleWidget.cpp 3b5e844 
>   src/lib/MarbleWidgetInputHandler.cpp 1bdba92 
>   src/lib/PopupItem.cpp 20391fc 
>   src/lib/Projections/SphericalProjection.cpp cebb73d 
>   src/lib/RenderPlugin.h 90355ed 
>   src/lib/RenderPlugin.cpp b9b95c9 
>   src/lib/ScanlineTextureMapperContext.cpp ff3197b 
>   src/lib/SphericalScanlineTextureMapper.h 85ee814 
>   src/lib/SphericalScanlineTextureMapper.cpp 0bfe09c 
>   src/lib/TextureColorizer.cpp 5319c21 
>   src/lib/VectorMap.cpp cf3dcef 
>   src/lib/ViewportParams.h 6b97f55 
>   src/lib/ViewportParams.cpp f82a8b7 
>   src/lib/layers/VectorMapLayer.cpp f05c88a 
>   src/lib/routing/RoutingInputWidget.cpp 28db48d 
>   src/lib/routing/RoutingLayer.cpp 125990d 
>   src/plugins/render/aprs/AprsPlugin.cpp 550192f 
>   src/plugins/render/atmosphere/AtmospherePlugin.cpp 492c111 
>   src/plugins/render/earthquake/EarthquakePlugin.cpp 1205521 
>   src/plugins/render/navigation/ArrowDiscWidget.h 77e5cdd 
>   src/plugins/render/navigation/ArrowDiscWidget.cpp ee81025 
>   src/plugins/render/opencachingcom/OpenCachingComPlugin.cpp 576198f 
>   src/plugins/render/opendesktop/OpenDesktopPlugin.cpp b1cef50 
>   src/plugins/render/photo/PhotoPlugin.cpp cdb6243 
>   src/plugins/render/postalcode/PostalCodePlugin.cpp 87feacd 
>   src/plugins/render/stars/StarsPlugin.cpp d8d1a08 
>   src/plugins/render/weather/WeatherPlugin.cpp 4be0c5d 
>   src/plugins/render/wikipedia/WikipediaPlugin.cpp 89cf51e 
> 
> Diff: http://git.reviewboard.kde.org/r/110058/diff/
> 
> 
> Testing
> -------
> 
> Ubuntu 11.40 32-bit / Qt 4.8.1
> 
> 
> File Attachments
> ----------------
> 
> Panned
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/04/16/17._Satellites.png
> Design Notes
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/05/15/Design_Notes.txt
> 
> 
> Thanks,
> 
> Paul Nader
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130515/e1840650/attachment.html>