[Marble-devel] Review Request 110403: Add support for reading the KML Model tag

[Dennis Nienhüser]

> On May 14, 2013, 7:10 p.m., Dennis Nienhüser wrote:
> > src/lib/geodata/data/GeoDataLocation.cpp, line 46
> > <http://git.reviewboard.kde.org/r/110403/diff/3/?file=143265#file143265line46>
> >
> >     Please call
> >     GeoDataGeometry::operator=( other );
> >     before

Sorry, rather GeoDataObject::operator=( other ), see above


> On May 14, 2013, 7:10 p.m., Dennis Nienhüser wrote:
> > src/lib/geodata/data/GeoDataLocation.h, line 23
> > <http://git.reviewboard.kde.org/r/110403/diff/3/?file=143264#file143264line23>
> >
> >     It's neither a GeoDataGeometry nor a GeoDataObject. Please don't derive from anything.

Sorry, it's a GeoDataObject, please change the inheritance to it.


> On May 14, 2013, 7:10 p.m., Dennis Nienhüser wrote:
> > src/lib/geodata/data/GeoDataOrientation.h, line 21
> > <http://git.reviewboard.kde.org/r/110403/diff/3/?file=143268#file143268line21>
> >
> >     It's neither a GeoDataGeometry nor a GeoDataObject. Please don't derive from anything

Sorry, it's a GeoDataObject, change the inheritance to it.


- Dennis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110403/#review32515
-----------------------------------------------------------


On May 12, 2013, 12:18 p.m., Sanjiban Bairagya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110403/
> -----------------------------------------------------------
> 
> (Updated May 12, 2013, 12:18 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Previously there was no way to read the <Model> tag in the kml files, if any. I added a few GeoData classes and tag-handlers which makes it possible now.
> 
> 
> This addresses bug 318288.
>     http://bugs.kde.org/show_bug.cgi?id=318288
> 
> 
> Diffs
> -----
> 
>   src/lib/geodata/CMakeLists.txt 1644d87 
>   src/lib/geodata/data/GeoDataAlias.h PRE-CREATION 
>   src/lib/geodata/data/GeoDataAlias.cpp PRE-CREATION 
>   src/lib/geodata/data/GeoDataGeometry.h 19cdd29 
>   src/lib/geodata/data/GeoDataLink.h 6cba0da 
>   src/lib/geodata/data/GeoDataLink.cpp 2c8f08b 
>   src/lib/geodata/data/GeoDataLocation.h PRE-CREATION 
>   src/lib/geodata/data/GeoDataLocation.cpp PRE-CREATION 
>   src/lib/geodata/data/GeoDataModel.h PRE-CREATION 
>   src/lib/geodata/data/GeoDataModel.cpp PRE-CREATION 
>   src/lib/geodata/data/GeoDataOrientation.h PRE-CREATION 
>   src/lib/geodata/data/GeoDataOrientation.cpp PRE-CREATION 
>   src/lib/geodata/data/GeoDataResourceMap.h PRE-CREATION 
>   src/lib/geodata/data/GeoDataResourceMap.cpp PRE-CREATION 
>   src/lib/geodata/data/GeoDataScale.h PRE-CREATION 
>   src/lib/geodata/data/GeoDataScale.cpp PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlAliasTagHandler.h PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlAliasTagHandler.cpp PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlAltitudeModeTagHandler.cpp 827293b 
>   src/lib/geodata/handlers/kml/KmlAltitudeTagHandler.h e34fd61 
>   src/lib/geodata/handlers/kml/KmlAltitudeTagHandler.cpp 6884dba 
>   src/lib/geodata/handlers/kml/KmlCoordinatesTagHandler.cpp 1d479fe 
>   src/lib/geodata/handlers/kml/KmlElementDictionary.h 11d9f1d 
>   src/lib/geodata/handlers/kml/KmlElementDictionary.cpp 36a1b0e 
>   src/lib/geodata/handlers/kml/KmlHeadingTagHandler.cpp a0c4801 
>   src/lib/geodata/handlers/kml/KmlHrefTagHandler.cpp 052d5b0 
>   src/lib/geodata/handlers/kml/KmlLatitudeTagHandler.h c11ca2b 
>   src/lib/geodata/handlers/kml/KmlLatitudeTagHandler.cpp 8040b97 
>   src/lib/geodata/handlers/kml/KmlLinkTagHandler.h 414face 
>   src/lib/geodata/handlers/kml/KmlLinkTagHandler.cpp a23acda 
>   src/lib/geodata/handlers/kml/KmlLocationTagHandler.h PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlLocationTagHandler.cpp PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlLongitudeTagHandler.h e8e81e4 
>   src/lib/geodata/handlers/kml/KmlLongitudeTagHandler.cpp 88f534b 
>   src/lib/geodata/handlers/kml/KmlModelTagHandler.h PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlModelTagHandler.cpp PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlOrientationTagHandler.h PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlOrientationTagHandler.cpp PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlRefreshModeTagHandler.cpp 21447fe 
>   src/lib/geodata/handlers/kml/KmlResourceMapTagHandler.h PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlResourceMapTagHandler.cpp PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlRollTagHandler.h 7aa69f3 
>   src/lib/geodata/handlers/kml/KmlRollTagHandler.cpp 22404bf 
>   src/lib/geodata/handlers/kml/KmlScaleTagHandler.h PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlScaleTagHandler.cpp PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlSourceHrefTagHandler.h PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlSourceHrefTagHandler.cpp PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlTargetHrefTagHandler.h PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlTargetHrefTagHandler.cpp PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlTiltTagHandler.cpp 806593c 
>   src/lib/geodata/handlers/kml/KmlXTagHandler.h PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlXTagHandler.cpp PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlYTagHandler.h PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlYTagHandler.cpp PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlZTagHandler.h PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlZTagHandler.cpp PRE-CREATION 
>   src/lib/geodata/parser/GeoDataTypes.h 1bc7828 
>   src/lib/geodata/parser/GeoDataTypes.cpp ec7c414 
>   tests/CMakeLists.txt d4cfec5 
>   tests/TestModel.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/110403/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sanjiban Bairagya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130514/b0c8d285/attachment.html>