[Marble-devel] Review Request 110387: Factor out ScreenLayer from GeometryLayer
Bernhard Beschow
bbeschow at cs.tu-berlin.de
Sat May 11 13:38:22 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110387/
-----------------------------------------------------------
Review request for Marble.
Description
-------
ScreenOverlays are fixed to the screen and are currently rendered by the GeometryLayer. According to the KML documentation, "Sample uses for ScreenOverlays are compasses, logos, and heads-up displays", so ScreenOverlays should (probably) be rendered in the "FLOAT_ITEMS" render position. Since GeometryLayer renders its objects in the "HOVERS_ABOVE_SURFACE" render position, the ScreenOverlay items should be moved into their own layer.
Diffs
-----
src/lib/MarbleMap.cpp b3334e8ba9bfb7d9ef93dc2ee4ce561f1cc3f015
src/lib/layers/CMakeLists.txt 4efe657038de29f86dcfde6a3d7b4c10da35a8c9
src/lib/layers/GeometryLayer.cpp 92d44f3fb5c6e2e199d501157ca7bb8cab6db161
src/lib/layers/ScreenLayer.h PRE-CREATION
src/lib/layers/ScreenLayer.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/110387/diff/
Testing
-------
Thanks,
Bernhard Beschow
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130511/9c1e2054/attachment.html>
More information about the Marble-devel
mailing list