[Marble-devel] Review Request 110222: Delete map themes properly

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110222/#review31826
-----------------------------------------------------------



src/lib/MapThemeManager.h
<http://git.reviewboard.kde.org/r/110222/#comment23729>

    typo: deleteDirecotry => deleteDirectory
    
    Can you add a comment to the method that warns against raising the visibility of this method to something else than private? I'd rather not have a 'rm -rf' method appear somewhere in the library after some future refactoring ;-)
    
    



src/lib/MapThemeManager.cpp
<http://git.reviewboard.kde.org/r/110222/#comment23730>

    Please use QFileInfo's methods instead



src/lib/MapThemeManager.cpp
<http://git.reviewboard.kde.org/r/110222/#comment23731>

    dir.exists()



src/lib/MapThemeManager.cpp
<http://git.reviewboard.kde.org/r/110222/#comment23732>

    const QFileInfo &info



src/lib/MapThemeManager.cpp
<http://git.reviewboard.kde.org/r/110222/#comment23733>

    should check result here as well


- Dennis Nienhüser


On April 27, 2013, 7:08 p.m., Utku Aydın wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110222/
> -----------------------------------------------------------
> 
> (Updated April 27, 2013, 7:08 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> This patch replaces existing map theme deletion method. The old method doesn't delete some files and because of that, users can't create a new theme with the same name.
> 
> 
> This addresses bug 318740.
>     http://bugs.kde.org/show_bug.cgi?id=318740
> 
> 
> Diffs
> -----
> 
>   src/lib/MapThemeManager.h 0728058 
>   src/lib/MapThemeManager.cpp 0c7d056 
> 
> Diff: http://git.reviewboard.kde.org/r/110222/diff/
> 
> 
> Testing
> -------
> 
> Created a WMS map, populated the theme folder by displaying different levels and deleted the theme.
> 
> 
> Thanks,
> 
> Utku Aydın
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130501/b6dd8d98/attachment.html>