[Marble-devel] Review Request 109061: LineString: move Tessellation out of projection code and fix cylindrical issues

[Thibaut Gridel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109061/
-----------------------------------------------------------

(Updated March 12, 2013, 6:09 p.m.)


Review request for Marble.


Changes
-------

According to first comments, tessellation will stay a projection issue.


Description
-------

Mostly code refactor and some fixes.
The goal is to separate concerns between projection specific issues and geodetic concerns.
Then corner cases for crossing the Idl, circling around a pole, moving past the horizon are easier to handle.


Diffs (updated)
-----

  src/lib/Projections/AbstractProjection.cpp d6faad5 
  src/lib/Projections/AbstractProjection_p.h 7284752 
  src/lib/Projections/CylindricalProjection.cpp be9d52a 
  tests/ViewportParamsTest.cpp 251a40e 

Diff: http://git.reviewboard.kde.org/r/109061/diff/


Testing
-------

ProjectionTest does sanitization checks that screen polygons must satisfy:
closed, contain more than 2 points, no same point twice, repeats


Thanks,

Thibaut Gridel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130312/1af8cdb2/attachment.html>