[Marble-devel] Review Request 109426: use GeoDataLatLonBox as boundary in GeoPolygon

Bernhard Beschow bbeschow at cs.tu-berlin.de
Mon Mar 11 23:22:52 UTC 2013

This is an automatically generated e-mail. To reply, visit:

(Updated March 11, 2013, 11:22 p.m.)


This change has been discarded.

Review request for Marble.


GeoPolygon is deprecated. In order to move away from this class, this patch attempts to solve its bounding box concerns the GeoData{Polygon, LineString, LinearRing} way (which make use of GeoDataLatLon(Alt)Box).

I wonder - in particular - if the spherical case works like before. I welcome any clues here. Thanks for your reviews!


  src/lib/GeoPolygon.h 37fb401d7b50a323ff9a3408d16065f7e56cac9c 
  src/lib/GeoPolygon.cpp efd8e9bd4bdf963535e562818d84e32def680009 
  src/lib/VectorMap.cpp cf3dcef082235374d0bdb9ea163a91a3055e4c1e 

Diff: http://git.reviewboard.kde.org/r/109426/diff/


Tested with "Atlas" theme in spherical and Mercator projection: The IDL seems to look the same as before and the continents seem to get colored correctly when zoomed in and out. Please verify since I'm not that familiar with the code.


Bernhard Beschow

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130311/ba0d134c/attachment.html>

More information about the Marble-devel mailing list