[Marble-devel] Review Request 110789: Unify copy'n'paste code of location <-> on route calculation

[Bernhard Beschow]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110789/#review34307
-----------------------------------------------------------


RoutingModelPrivate::deviatedFromRoute() isn't used anyway, so the code duplication can be resolved by removing the method.

- Bernhard Beschow


On June 2, 2013, 9:16 p.m., Thomas Jarosch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110789/
> -----------------------------------------------------------
> 
> (Updated June 2, 2013, 9:16 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Hi,
> 
> the code in RoutingModelPrivate::deviatedFromRoute() and RoutingModel::updatePosition()
> to check if we are still on the right route is almost identical -> unify it.
> 
> Only the EARTH_RADIUS factor is moved to a different part of the "formula",
> the result should still be the same.
> 
> Thomas
> 
> 
> Diffs
> -----
> 
>   src/lib/routing/RoutingModel.cpp 2cd9afb 
> 
> Diff: http://git.reviewboard.kde.org/r/110789/diff/
> 
> 
> Testing
> -------
> 
> Tested with the "current route" simulator, not on the N900 yet.
> 
> 
> Thanks,
> 
> Thomas Jarosch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130613/ebde9325/attachment.html>