[Marble-devel] Review Request 110735: Route manager: Fix loading routes with less via points than currently active

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110735/
-----------------------------------------------------------

(Updated June 1, 2013, 8:46 a.m.)


Status
------

This change has been marked as submitted.


Review request for Marble.


Description
-------

Hi,

when you load a route with less via points than currently active vias,
the intention of the code was to remove all unneeded via points.

The logic to do this was broken: Every time you remove an element,
m_RouteRequest.size() will also decrement -> one element was always left over.

Attached patch fixes this.

*** Steps to reproduce ***
Create a normal route with two vias and save it.
Clear the route, create a new one and add some random vias.

If you now load the route with the two via points,
one previous via point is left over.

Thomas


Diffs
-----

  src/lib/routing/RoutingManager.cpp c0554cf 

Diff: http://git.reviewboard.kde.org/r/110735/diff/


Testing
-------

Tested on desktop Qt version.


Thanks,

Thomas Jarosch

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130601/07f0098b/attachment.html>