[Marble-devel] Review Request 111753: Add i18n context for satellite groups

Dennis Nienhüser earthwings at gentoo.org
Mon Jul 29 17:44:08 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111753/#review36769
-----------------------------------------------------------

Ship it!


Ship It!

- Dennis Nienhüser


On July 27, 2013, 9:55 p.m., Lasse Liehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111753/
> -----------------------------------------------------------
> 
> (Updated July 27, 2013, 9:55 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> This helps translators and also prevents a wrong translation of "Other" or "Education" being used. Without additional context for example the translation of "Education" (the satellite group) is taken from the "marble" catalog (where "Education" means a map legend group) and not from the correct "marble_qt" catalog. This is because "marble" is the primary catalog (at least for the KDE GUI) and that is searched first.
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/satellites/SatellitesPlugin.cpp 922eaee 
> 
> Diff: http://git.reviewboard.kde.org/r/111753/diff/
> 
> 
> Testing
> -------
> 
> Started Marble and nothing seemed to be broken in the satellites configuration dialog.
> 
> 
> Thanks,
> 
> Lasse Liehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130729/3f8f72d6/attachment.html>


More information about the Marble-devel mailing list