[Marble-devel] Review Request 111733: Use generic OS X fullscreen method

[Bernhard Beschow]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111733/#review36761
-----------------------------------------------------------



src/QtMainWindow.cpp
<http://git.reviewboard.kde.org/r/111733/#comment27139>

    Hmm, these comments tend to become outdated...



src/QtMainWindow.cpp
<http://git.reviewboard.kde.org/r/111733/#comment27140>

    ... why not add a more descriptive commet here?



src/QtMainWindow.cpp
<http://git.reviewboard.kde.org/r/111733/#comment27141>

    This statement is executed in both branches. Can you simplify the if statement to have only one branch and execute MarbleMac::toggleFullscreen() after the if-Statement?


- Bernhard Beschow


On July 29, 2013, 4:59 p.m., Mohammed Nafees wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111733/
> -----------------------------------------------------------
> 
> (Updated July 29, 2013, 4:59 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> This patch enables Marble to use the native OS X full screen method/way which makes it more customized for OS X.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 69c2fbe 
>   src/CMakeLists.txt b2a3e09 
>   src/QtMainWindow.cpp 378cc81 
>   src/mac/MarbleMac.h PRE-CREATION 
>   src/mac/MarbleMac.mm PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111733/diff/
> 
> 
> Testing
> -------
> 
> Testing done and works!
> 
> 
> Thanks,
> 
> Mohammed Nafees
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130729/97b3ee1a/attachment.html>