[Marble-devel] Review Request 111499: GroundOverlay Rendering

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111499/#review36452
-----------------------------------------------------------



src/lib/MergedLayerDecorator.cpp
<http://git.reviewboard.kde.org/r/111499/#comment26909>

    I suggest you just create a overlayLatLonBox variable. Then you can save latNorth/South/West/East and use just 
    overlayLatLonBox.north() - overlayLatLonBox.south() 
    and the same for east/west in the only lines which use this: 276 and 277. ;)
    And you can reuse it elsewhere.


- Torsten Rahn


On July 24, 2013, 4:45 p.m., Adrian Draghici wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111499/
> -----------------------------------------------------------
> 
> (Updated July 24, 2013, 4:45 p.m.)
> 
> 
> Review request for Marble, Bernhard Beschow, Dennis Nienhüser, Torsten Rahn, and Thibaut Gridel.
> 
> 
> Description
> -------
> 
> This patch adds support for rendering GroundOverlays. A model with filtered GroundOverlays is saved in MarbleModel and used in TextureLayer, where the cache of GroundOverlays is handled. The actual rendering takes place in MergedLayerDecorator.
> 
> 
> Diffs
> -----
> 
>   src/lib/MarbleMap.cpp 102ed0d 
>   src/lib/MarbleModel.h 44a5f61 
>   src/lib/MarbleModel.cpp 3c44f9d 
>   src/lib/MergedLayerDecorator.h 2823cfc 
>   src/lib/MergedLayerDecorator.cpp 6363d8e 
>   src/lib/layers/TextureLayer.h 1dbd114 
>   src/lib/layers/TextureLayer.cpp 5b9e9c9 
> 
> Diff: http://git.reviewboard.kde.org/r/111499/diff/
> 
> 
> Testing
> -------
> 
> Tested with multiple overlapping overlays, different rotation angles.
> 
> 
> Thanks,
> 
> Adrian Draghici
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130724/b278f182/attachment.html>