[Marble-devel] Review Request 111488: Use only vertical WheelEvent for zooming

Dennis Nienhüser earthwings at gentoo.org
Mon Jul 22 13:09:44 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111488/#review36292
-----------------------------------------------------------



src/lib/MarbleWidgetInputHandler.cpp
<http://git.reviewboard.kde.org/r/111488/#comment26831>

    Would returning false work as well? Then other event listeners have a chance to handle this event.
    


- Dennis Nienhüser


On July 12, 2013, 4:20 a.m., Nikita Skovoroda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111488/
> -----------------------------------------------------------
> 
> (Updated July 12, 2013, 4:20 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Solves jitter issues on touchpads with both vertical and horizontal two-finger scroll enabled.
> 
> On such touchpads, it is very easy to trigger both horizontal and vertical wheel events by moving fingers in the direction that slightly differs from straight horizontal or straight vertical direction.
> When the deltas of that events have opposite signs, a jitter-like effect happens if both vertical and horizontal wheel events are bound to the same zoom action.
> 
> 
> Diffs
> -----
> 
>   src/lib/MarbleWidgetInputHandler.cpp 310bbce 
> 
> Diff: http://git.reviewboard.kde.org/r/111488/diff/
> 
> 
> Testing
> -------
> 
> It compiles, runs, and has the desired effect.
> 
> Horizontal wheel events are now ignored, and no jitter happens for me.
> 
> 
> Thanks,
> 
> Nikita Skovoroda
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130722/44deb0c4/attachment.html>


More information about the Marble-devel mailing list