[Marble-devel] Review Request 108632: Basic .kmz support

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108632/
-----------------------------------------------------------

(Updated Jan. 30, 2013, 6:49 p.m.)


Review request for Marble.


Changes
-------

- Use '/' instead of "/"
- Introduce KmlDocument for temporary file tracking


Description
-------

Extends the kml plugin to support opening .kmz files.

- ParseRunner gets access to MarbleModel
- KML plugin has an optional dependency on quazip
- When opening a .kmz file, quazip is used to extract the .kmz to a temporary location
- Last .kml file found in the .kmz is opened
- If the .kml is closed in Marble, the temporary files are removed


This addresses bug 310059.
    http://bugs.kde.org/show_bug.cgi?id=310059


Diffs (updated)
-----

  cmake/modules/Findquazip.cmake PRE-CREATION 
  src/plugins/runner/kml/CMakeLists.txt 35e00dc 
  src/plugins/runner/kml/KmlDocument.h PRE-CREATION 
  src/plugins/runner/kml/KmlDocument.cpp PRE-CREATION 
  src/plugins/runner/kml/KmlParser.h a5e4c5f 
  src/plugins/runner/kml/KmlParser.cpp b2ff585 
  src/plugins/runner/kml/KmlPlugin.cpp fc23402 
  src/plugins/runner/kml/KmlRunner.cpp 3278c78 
  src/plugins/runner/kml/KmzHandler.h PRE-CREATION 
  src/plugins/runner/kml/KmzHandler.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/108632/diff/


Testing
-------

Opening some random .kmz files found on the Internet works.

TODO (for separate patches):
- Resolve files (images) in .kmz files correctly
- Fix Marble to delete plugins / close files correctly on shutdown
- Register .kmz files for opening with Marble


Thanks,

Dennis Nienhüser

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130130/b024c31f/attachment.html>