[Marble-devel] Review Request 108618: Annotate: a plugin to draw polygons and placemarks on a map

Tue Jan 29 20:34:56 UTC 2013

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108618/
-----------------------------------------------------------

(Updated Jan. 29, 2013, 8:34 p.m.)

Review request for Marble.

Changes
-------

Fixed all remarks.
Fixed a crash with dangling selected item.
Improved rendering of "to be created" polygon.

Description
-------

The revival of osmannotate plugin which never got to release state.
The plugin layer handles SceneGraphicsItems for mouse event actions, and updates a document which is rendered with classical layers.
Still lots of work needed for production delivery, but already quite functionnal:
- Adds/Removes Point Placemarks, Polygons
- Import/Export to kml file
- Move Polygon points to reshape
- Placemark "edit bubble" which sets name and description

Needs work:
edit bubble is weak with painting and refreshing
"download osm" not touched, should be dropped from this plugin imho

The full work is available in a git branch (which will be rebased to commit to master):
git://anongit.kde.org/clones/marble/tgridel/marble.git:annotate

Diffs (updated)
-----

  data/bitmaps/annotation.png 330dea6 
  data/bitmaps/hand.png 0a7276c 
  src/QtMainWindow.cpp 9224240 
  src/icons/document-export.png PRE-CREATION 
  src/icons/document-import.png PRE-CREATION 
  src/icons/draw-placemark.png PRE-CREATION 
  src/icons/draw-polygon.png PRE-CREATION 
  src/icons/edit-delete-shred.png PRE-CREATION 
  src/icons/hand.png PRE-CREATION 
  src/icons/remove.png PRE-CREATION 
  src/lib/RenderPlugin.h 577da7a 
  src/lib/RenderPlugin.cpp 18360cc 
  src/marble.qrc 7fcc47f 
  src/marble_part.cpp c6ec40a 
  src/plugins/render/CMakeLists.txt 4d726b7 
  src/plugins/render/annotate/AnnotatePlugin.h PRE-CREATION 
  src/plugins/render/annotate/AnnotatePlugin.cpp PRE-CREATION 
  src/plugins/render/annotate/AreaAnnotation.h PRE-CREATION 
  src/plugins/render/annotate/AreaAnnotation.cpp PRE-CREATION 
  src/plugins/render/annotate/CMakeLists.txt PRE-CREATION 
  src/plugins/render/annotate/GeoWidgetBubble.h PRE-CREATION 
  src/plugins/render/annotate/GeoWidgetBubble.cpp PRE-CREATION 
  src/plugins/render/annotate/PlacemarkTextAnnotation.h PRE-CREATION 
  src/plugins/render/annotate/PlacemarkTextAnnotation.cpp PRE-CREATION 
  src/plugins/render/annotate/SceneGraphicsItem.h PRE-CREATION 
  src/plugins/render/annotate/SceneGraphicsItem.cpp PRE-CREATION 
  src/plugins/render/annotate/TextEditor.h PRE-CREATION 
  src/plugins/render/annotate/TextEditor.cpp PRE-CREATION 
  src/plugins/render/osmannotate/AreaAnnotation.h 6bfbc3e 
  src/plugins/render/osmannotate/AreaAnnotation.cpp ecabb14 
  src/plugins/render/osmannotate/CMakeLists.txt e4297b1 
  src/plugins/render/osmannotate/GeoWidgetBubble.h c7fe77c 
  src/plugins/render/osmannotate/GeoWidgetBubble.cpp 45f0fd8 
  src/plugins/render/osmannotate/OsmAnnotatePlugin.h 52f7579 
  src/plugins/render/osmannotate/OsmAnnotatePlugin.cpp 269db35 
  src/plugins/render/osmannotate/PlacemarkTextAnnotation.h 04fe56e 
  src/plugins/render/osmannotate/PlacemarkTextAnnotation.cpp 9ad300d 
  src/plugins/render/osmannotate/TextAnnotation.h a3235c2 
  src/plugins/render/osmannotate/TextAnnotation.cpp e58c175 
  src/plugins/render/osmannotate/TextEditor.h 59e68a5 
  src/plugins/render/osmannotate/TextEditor.cpp 689f724 
  src/plugins/render/osmannotate/TmpGraphicsItem.h 3526191 
  src/plugins/render/osmannotate/TmpGraphicsItem.cpp 4fcf1b4 
  src/plugins/render/osmannotate/osm/OsmBoundsGraphicsItem.h 25420be 
  src/plugins/render/osmannotate/osm/OsmBoundsGraphicsItem.cpp f3db2d8 
  src/plugins/render/osmannotate/osm/OsmBoundsTagHandler.h ee1e085 
  src/plugins/render/osmannotate/osm/OsmBoundsTagHandler.cpp 0341a0e 
  src/plugins/render/osmannotate/osm/OsmElementDictionary.h 02f558e 
  src/plugins/render/osmannotate/osm/OsmElementDictionary.cpp 3941751 
  src/plugins/render/osmannotate/osm/OsmNdTagHandler.h c797d9f 
  src/plugins/render/osmannotate/osm/OsmNdTagHandler.cpp 21c95b2 
  src/plugins/render/osmannotate/osm/OsmNodeGraphicsItem.h 5147471 
  src/plugins/render/osmannotate/osm/OsmNodeGraphicsItem.cpp ac319e3 
  src/plugins/render/osmannotate/osm/OsmNodeTagHandler.h dc8a978 
  src/plugins/render/osmannotate/osm/OsmNodeTagHandler.cpp 52e3959 
  src/plugins/render/osmannotate/osm/OsmWayGraphicsItem.h 1e15bbd 
  src/plugins/render/osmannotate/osm/OsmWayGraphicsItem.cpp db01729 
  src/plugins/render/osmannotate/osm/OsmWayTagHandler.h 85fa75f 
  src/plugins/render/osmannotate/osm/OsmWayTagHandler.cpp 357948b 

Diff: http://git.reviewboard.kde.org/r/108618/diff/

Testing
-------

File Attachments
----------------

Toolbar
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/27/annotate1.jpg
Placemark bubble
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/27/annotate2.jpg
Area
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/27/annotate3.jpg
Moved Area
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/27/annotate4.jpg
TreeModel
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/27/annotate5.jpg

Thanks,

Thibaut Gridel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130129/d3d09a3d/attachment.html>