[Marble-devel] Review Request 108632: Basic .kmz support
Dennis Nienhüser
earthwings at gentoo.org
Sun Jan 27 19:16:32 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108632/
-----------------------------------------------------------
Review request for Marble.
Description
-------
Extends the kml plugin to support opening .kmz files.
- ParseRunner gets access to MarbleModel
- KML plugin has an optional dependency on quazip
- When opening a .kmz file, quazip is used to extract the .kmz to a temporary location
- Last .kml file found in the .kmz is opened
- If the .kml is closed in Marble, the temporary files are removed
This addresses bug 310059.
http://bugs.kde.org/show_bug.cgi?id=310059
Diffs
-----
cmake/modules/Findquazip.cmake PRE-CREATION
src/lib/FileLoader.cpp 93d7db0
src/lib/MarbleRunnerManager.cpp 1b312b1
src/lib/ParsingRunner.h 033fe60
src/lib/ParsingRunner.cpp 81458ce
src/lib/RunnerTask.h 956fd93
src/lib/RunnerTask.cpp 56f0628
src/plugins/runner/kml/CMakeLists.txt 35e00dc
src/plugins/runner/kml/KmlPlugin.h 527c2f1
src/plugins/runner/kml/KmlPlugin.cpp fc23402
src/plugins/runner/kml/KmlRunner.h d97f89a
src/plugins/runner/kml/KmlRunner.cpp 3278c78
src/plugins/runner/kml/KmzHandler.h PRE-CREATION
src/plugins/runner/kml/KmzHandler.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/108632/diff/
Testing
-------
Opening some random .kmz files found on the Internet works.
TODO (for separate patches):
- Resolve files (images) in .kmz files correctly
- Fix Marble to delete plugins / close files correctly on shutdown
- Register .kmz files for opening with Marble
Thanks,
Dennis Nienhüser
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130127/8e318c8a/attachment-0001.html>
More information about the Marble-devel
mailing list