[Marble-devel] Review Request 108511: Template System + MarbleLegendBrowser + HTML5 (Woo Hoo)

Fri Jan 25 21:39:12 UTC 2013

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108511/
-----------------------------------------------------------

(Updated Jan. 25, 2013, 9:39 p.m.)

Review request for Marble, Dennis Nienhüser, Torsten Rahn, and René Küttner.

Changes
-------

Issues + appearence.

Description
-------

A list of changes:

- Fixed Cities bug
- Added TemplateDocument class for templating things
- MarbleLegendBrowser tweaked (support of cool image borders, nice fonts, everything Bootstrap has)
- Added support of Bootstrap (http://twitter.github.com/bootstrap/index.html) in HTML of Marble
- MapInfoDialog improved (see MarbleLegendBrowser changes)

More about TemplateDocument:

- It use %var_name% to template the text
- String format %!{name}% will include library `name` into the HTML. Used in <head> tag

Diffs (updated)
-----

  src/lib/geodata/CMakeLists.txt 9c718cc 
  src/lib/TemplateDocument.cpp PRE-CREATION 
  src/lib/TemplateDocument.h PRE-CREATION 
  src/lib/MarbleLegendBrowser.cpp fad7020 
  src/lib/MarbleWidgetPopupMenu.cpp eb608be 
  src/lib/MapViewWidget.cpp da686ea 
  src/lib/CMakeLists.txt 59ad8d2 
  data/maps/earth/schagen1689/legend.html db3f171 
  data/maps/earth/openstreetmap/legend.html aa02426 
  data/maps/earth/openstreetmap/openstreetmap.dgml e4b3c4b 
  data/legend.html 317b6cf 
  src/lib/geodata/data/GeoDataPlaylist.h 516d490 
  src/lib/geodata/data/GeoDataPlaylist.cpp 769fd2d 
  src/lib/geodata/data/GeoDataTour.h b151b44 
  src/lib/geodata/data/GeoDataTour.cpp 9c49626 
  src/lib/geodata/data/GeoDataTourControl.h 133ee46 
  src/lib/geodata/data/GeoDataTourControl.cpp 0892288 
  src/lib/geodata/data/GeoDataTourPrimitive.h c665e88 
  src/lib/geodata/handlers/kml/KmlElementDictionary.h 11d9f1d 
  src/lib/geodata/handlers/kml/KmlElementDictionary.cpp 36a1b0e 
  src/lib/geodata/handlers/kml/KmlPlacemarkTagHandler.cpp 8dd62cb 
  src/lib/geodata/handlers/kml/KmlPlaylistTagHandler.h 3b1d203 
  src/lib/geodata/handlers/kml/KmlPlaylistTagHandler.cpp 36be12a 
  src/lib/geodata/handlers/kml/KmlTourControlTagHandler.h c9a6c10 
  src/lib/geodata/handlers/kml/KmlTourControlTagHandler.cpp 5961c5e 
  src/lib/geodata/handlers/kml/KmlplayModeTagHandler.h a8f7405 
  src/lib/geodata/handlers/kml/KmlplayModeTagHandler.cpp e06edc5 
  src/lib/htmlfeatures/bootstrap.inc PRE-CREATION 
  src/lib/htmlfeatures/bootstrap.min.css PRE-CREATION 
  src/lib/libmarble.qrc 7753834 
  src/lib/webpopup/city.html 764f3c3 
  src/lib/webpopup/geoplace.html 4abca92 
  src/lib/webpopup/nation.html 4bfe9a0 
  src/lib/webpopup/placesscreen.css b25f73d 
  src/lib/webpopup/skyplace.html 707f30f 
  src/plugins/positionprovider/gpsd/GpsdPositionProviderPlugin.cpp 0ce3196 
  tests/CMakeLists.txt cd16f98 
  tests/TestTour.cpp 68c5f1f 

Diff: http://git.reviewboard.kde.org/r/108511/diff/

Testing
-------

Tested on Qt version of Marble - everything is ok. Tests are passed.

File Attachments
----------------

Old Historic Legend
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/compare-historic-old.png
Old OSM Legend
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/compare-osm-old.png
New Histroric Legend
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/compare-historic-new.png
Old Temperature Legend
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/compare-temp-old.png
New OSM Legend
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/compare-osm-new.png
New Temperature Legend
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/compare-temp-new.png
New MapInfoDialog
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/compare-ukraine-new.png

Thanks,

Illya Kovalevskyy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130125/04f8fe36/attachment.html>