[Marble-devel] Review Request 108511: Template System + MarbleLegendBrowser + HTML5 (Woo Hoo)

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108511/#review25868
-----------------------------------------------------------



data/maps/earth/schagen1689/legend.html
<http://git.reviewboard.kde.org/r/108511/#comment19739>

    What is this doing? :-)
    
    And what happens if this line is missing?



data/maps/earth/schagen1689/legend.html
<http://git.reviewboard.kde.org/r/108511/#comment19740>

    See above.
    



src/lib/MarbleLegendBrowser.cpp
<http://git.reviewboard.kde.org/r/108511/#comment19741>

    Please describe in a comment what this particular "repair" line does.



src/lib/TemplateDocument.h
<http://git.reviewboard.kde.org/r/108511/#comment19742>

    There should be some API docs that describe what this class is about.



src/lib/TemplateDocument.h
<http://git.reviewboard.kde.org/r/108511/#comment19743>

    What is the value property about? Please add some comment.



src/lib/TemplateDocument.h
<http://git.reviewboard.kde.org/r/108511/#comment19744>

    What does the htmlFeatures property control?


- Torsten Rahn


On Jan. 20, 2013, 8:44 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108511/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2013, 8:44 p.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser, Torsten Rahn, and René Küttner.
> 
> 
> Description
> -------
> 
> A list of changes:
> 
> - Fixed Cities bug
> - Added TemplateDocument class for templating things
> - MarbleLegendBrowser tweaked (support of cool image borders, nice fonts, everything Bootstrap has)
> - Added support of Bootstrap (http://twitter.github.com/bootstrap/index.html) in HTML of Marble
> - MapInfoDialog improved (see MarbleLegendBrowser changes)
> 
> 
> Diffs
> -----
> 
>   data/maps/earth/schagen1689/legend.html db3f171 
>   src/lib/CMakeLists.txt 59ad8d2 
>   src/lib/MarbleLegendBrowser.cpp fad7020 
>   src/lib/MarbleWidgetPopupMenu.cpp eb608be 
>   src/lib/TemplateDocument.h PRE-CREATION 
>   src/lib/TemplateDocument.cpp PRE-CREATION 
>   src/lib/htmlfeatures/bootstrap-responsive.css PRE-CREATION 
>   src/lib/htmlfeatures/bootstrap.css PRE-CREATION 
>   src/lib/htmlfeatures/bootstrap.js PRE-CREATION 
>   src/lib/htmlfeatures/bootstrap.tpl PRE-CREATION 
>   src/lib/htmlfeatures/jquery-latest.js PRE-CREATION 
>   src/lib/htmlfeatures/jquery.tpl PRE-CREATION 
>   src/lib/libmarble.qrc 7753834 
>   src/lib/webpopup/city.html 764f3c3 
>   src/lib/webpopup/geoplace.html 4abca92 
>   src/lib/webpopup/nation.html 4bfe9a0 
>   src/lib/webpopup/placesscreen.css b25f73d 
>   src/lib/webpopup/skyplace.html 707f30f 
> 
> Diff: http://git.reviewboard.kde.org/r/108511/diff/
> 
> 
> Testing
> -------
> 
> Tested on Qt version of Marble - everything is ok. Tests are passed.
> 
> 
> File Attachments
> ----------------
> 
> Updated (not tweaked) OSM
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/mega-2.png
> Tweaked History Map
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/mega-1.png
> Improved also. Not very visible - but there are few visual changes
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/mega-3.png
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130120/13138337/attachment.html>