[Marble-devel] Review Request 108392: Add support for moons in the Celestial bodies selector

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108392/#review25763
-----------------------------------------------------------



src/lib/MapViewWidget.cpp
<http://git.reviewboard.kde.org/r/108392/#comment19604>

    Could you describe as a comment what this part does exactly



src/lib/MapViewWidget.cpp
<http://git.reviewboard.kde.org/r/108392/#comment19605>

    // TODO: create priority on the model side (Planet Class) by taking the distance to the "home planet/home star" into account



src/lib/MapViewWidget.cpp
<http://git.reviewboard.kde.org/r/108392/#comment19606>

    What gets removed here? 
    The string from the id or from the name? If it's from the name it would need to take translation into account ...


- Torsten Rahn


On Jan. 18, 2013, 7:28 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108392/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2013, 7:28 p.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser, Torsten Rahn, and René Küttner.
> 
> 
> Description
> -------
> 
> Add support for moons in the Celestial bodies selector
> 
> * https://google-melange.appspot.com/gci/task/view/google/gci2012/8083204
> 
> 
> Diffs
> -----
> 
>   src/lib/MapViewWidget.cpp 675af34 
> 
> Diff: http://git.reviewboard.kde.org/r/108392/diff/
> 
> 
> Testing
> -------
> 
> Everything is OK.
> 
> 
> File Attachments
> ----------------
> 
> Current View
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/17/screen-alp-1.png
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130118/a620bae0/attachment-0001.html>