[Marble-devel] Review Request 108473: Name and Description tag in GeoDataTour

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108473/#review25753
-----------------------------------------------------------


Looks good. Ideally you'd adjust TestTour.cpp as well to check for the two tags as well. That needs https://git.reviewboard.kde.org/r/108369/ to be comitted first, though.


src/lib/geodata/data/GeoDataTour.h
<http://git.reviewboard.kde.org/r/108473/#comment19595>

    const QString &name



src/lib/geodata/data/GeoDataTour.h
<http://git.reviewboard.kde.org/r/108473/#comment19596>

    const QString &description


- Dennis Nienhüser


On Jan. 18, 2013, 2:04 p.m., Mayank Madan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108473/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2013, 2:04 p.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser and Torsten Rahn.
> 
> 
> Description
> -------
> 
> Name and Desciption tag in GeoDataTour and added GeoDataTour class in KmlNameTagHandler and KmlDescriptionTagHandler
> 
> 
> Diffs
> -----
> 
>   src/lib/geodata/data/GeoDataTour.h bdda340 
>   src/lib/geodata/data/GeoDataTour.cpp 1260fc3 
>   src/lib/geodata/handlers/kml/KmlDescriptionTagHandler.cpp 84758c6 
>   src/lib/geodata/handlers/kml/KmlNameTagHandler.cpp c80dcc2 
> 
> Diff: http://git.reviewboard.kde.org/r/108473/diff/
> 
> 
> Testing
> -------
> 
> Yep, compiled without any errors
> 
> 
> Thanks,
> 
> Mayank Madan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130118/ac8a5ff4/attachment.html>