[Marble-devel] Review Request 108369: Implement support for gx:TourControl and its base classes

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108369/#review25742
-----------------------------------------------------------



src/lib/geodata/data/GeoDataPlaylist.h
<http://git.reviewboard.kde.org/r/108369/#comment19578>

    Can you add another method, please:
    const GeoDataTourPrimitive* primitive(int id) const;
    



src/lib/geodata/data/GeoDataPlaylist.cpp
<http://git.reviewboard.kde.org/r/108369/#comment19579>

    curly brackets missing



src/lib/geodata/data/GeoDataTour.h
<http://git.reviewboard.kde.org/r/108369/#comment19582>

    const QString &



src/lib/geodata/data/GeoDataTour.h
<http://git.reviewboard.kde.org/r/108369/#comment19580>

    Can you add another method, please:
    const GeoDataPlaylist* playlist() const;



src/lib/geodata/data/GeoDataTour.cpp
<http://git.reviewboard.kde.org/r/108369/#comment19581>

    m_playlist( 0 )
    



src/lib/geodata/data/GeoDataTourControl.h
<http://git.reviewboard.kde.org/r/108369/#comment19583>

    first enum value will be 0 anyway



src/lib/geodata/handlers/kml/KmlPlaylistTagHandler.cpp
<http://git.reviewboard.kde.org/r/108369/#comment19584>

    shouldn't it return the playlist here?



src/lib/geodata/handlers/kml/KmlTourControlTagHandler.cpp
<http://git.reviewboard.kde.org/r/108369/#comment19585>

    shouldn't it return tourControl here?



tests/TestTour.cpp
<http://git.reviewboard.kde.org/r/108369/#comment19586>

    can you insert a playmode tag as well and test for it?
    


- Dennis Nienhüser


On Jan. 17, 2013, 10:38 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108369/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2013, 10:38 p.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser, Torsten Rahn, and René Küttner.
> 
> 
> Description
> -------
> 
> Implement support for gx:TourControl and its base classes acc. to the GCI task:
>  - http://www.google-melange.com/gci/task/view/google/gci2012/8231204
> 
> 
> Diffs
> -----
> 
>   src/lib/geodata/CMakeLists.txt 0704354 
>   src/lib/geodata/data/GeoDataPlaylist.h PRE-CREATION 
>   src/lib/geodata/data/GeoDataPlaylist.cpp PRE-CREATION 
>   src/lib/geodata/data/GeoDataTour.h bdda340 
>   src/lib/geodata/data/GeoDataTour.cpp 1260fc3 
>   src/lib/geodata/data/GeoDataTourControl.h PRE-CREATION 
>   src/lib/geodata/data/GeoDataTourControl.cpp PRE-CREATION 
>   src/lib/geodata/data/GeoDataTourPrimitive.h PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlElementDictionary.h c0d6a57 
>   src/lib/geodata/handlers/kml/KmlElementDictionary.cpp 25b9924 
>   src/lib/geodata/handlers/kml/KmlPlacemarkTagHandler.cpp 8a9dcbb 
>   src/lib/geodata/handlers/kml/KmlPlaylistTagHandler.h PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlPlaylistTagHandler.cpp PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlTourControlTagHandler.h PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlTourControlTagHandler.cpp PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlplayModeTagHandler.h PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlplayModeTagHandler.cpp PRE-CREATION 
>   tests/CMakeLists.txt f78c2f1 
>   tests/TestTour.cpp b472668 
> 
> Diff: http://git.reviewboard.kde.org/r/108369/diff/
> 
> 
> Testing
> -------
> 
> Everything is OK.
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130118/a19fcaca/attachment-0001.html>