[Marble-devel] Review Request 108369: Implement support for gx:TourControl and its base classes

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108369/#review25376
-----------------------------------------------------------


The test case doesn't work yet.


src/lib/geodata/data/GeoDataPlaylist.h
<http://git.reviewboard.kde.org/r/108369/#comment19401>

    2013



src/lib/geodata/data/GeoDataPlaylist.h
<http://git.reviewboard.kde.org/r/108369/#comment19416>

    add GEODATA_EXPORT



src/lib/geodata/data/GeoDataPlaylist.h
<http://git.reviewboard.kde.org/r/108369/#comment19402>

    Please add an int size() const method



src/lib/geodata/data/GeoDataPlaylist.cpp
<http://git.reviewboard.kde.org/r/108369/#comment19403>

    curly brackets missing
    please also check for id < 0



src/lib/geodata/data/GeoDataTour.h
<http://git.reviewboard.kde.org/r/108369/#comment19404>

    copy constructor and assignment operator need overloading (because of the pointer member)



src/lib/geodata/data/GeoDataTour.h
<http://git.reviewboard.kde.org/r/108369/#comment19407>

    KML reference says a tour can have just one playlist, not multiple.



src/lib/geodata/data/GeoDataTour.cpp
<http://git.reviewboard.kde.org/r/108369/#comment19405>

    m_id



src/lib/geodata/data/GeoDataTourControl.h
<http://git.reviewboard.kde.org/r/108369/#comment19415>

    add GEODATA_EXPORT



src/lib/geodata/data/GeoDataTourControl.h
<http://git.reviewboard.kde.org/r/108369/#comment19409>

    i'm missing the playMode getter/setter



tests/TestTour.cpp
<http://git.reviewboard.kde.org/r/108369/#comment19417>

    misses inclusion in tests/CMakeLists.txt



tests/TestTour.cpp
<http://git.reviewboard.kde.org/r/108369/#comment19412>

    lacks closing "



tests/TestTour.cpp
<http://git.reviewboard.kde.org/r/108369/#comment19421>

    



tests/TestTour.cpp
<http://git.reviewboard.kde.org/r/108369/#comment19422>

    



tests/TestTour.cpp
<http://git.reviewboard.kde.org/r/108369/#comment19413>

    misses cast



tests/TestTour.cpp
<http://git.reviewboard.kde.org/r/108369/#comment19414>

    misses cast



tests/TestTour.cpp
<http://git.reviewboard.kde.org/r/108369/#comment19420>

    QString( "" )



tests/TestTour.cpp
<http://git.reviewboard.kde.org/r/108369/#comment19419>

    QString( "tourId" )



tests/TestTour.cpp
<http://git.reviewboard.kde.org/r/108369/#comment19410>

    dynamic_cast



tests/TestTour.cpp
<http://git.reviewboard.kde.org/r/108369/#comment19418>

    QString( "space" )


- Dennis Nienhüser


On Jan. 12, 2013, 2:58 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108369/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2013, 2:58 p.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser, Torsten Rahn, and René Küttner.
> 
> 
> Description
> -------
> 
> Implement support for gx:TourControl and its base classes acc. to the GCI task:
>  - http://www.google-melange.com/gci/task/view/google/gci2012/8231204
> 
> 
> Diffs
> -----
> 
>   src/lib/geodata/CMakeLists.txt e3f335d 
>   src/lib/geodata/data/GeoDataPlaylist.h PRE-CREATION 
>   src/lib/geodata/data/GeoDataPlaylist.cpp PRE-CREATION 
>   src/lib/geodata/data/GeoDataTour.h PRE-CREATION 
>   src/lib/geodata/data/GeoDataTour.cpp PRE-CREATION 
>   src/lib/geodata/data/GeoDataTourControl.h PRE-CREATION 
>   src/lib/geodata/data/GeoDataTourControl.cpp PRE-CREATION 
>   src/lib/geodata/data/GeoDataTourPrimitive.h PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlElementDictionary.h 16da3d3 
>   src/lib/geodata/handlers/kml/KmlElementDictionary.cpp 57d07d3 
>   src/lib/geodata/handlers/kml/KmlPlacemarkTagHandler.cpp 7ee1b02 
>   src/lib/geodata/handlers/kml/KmlPlaylistTagHandler.h PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlPlaylistTagHandler.cpp PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlTourControlTagHandler.h PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlTourControlTagHandler.cpp PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlTourTagHandler.h PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlTourTagHandler.cpp PRE-CREATION 
>   tests/TestTour.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/108369/diff/
> 
> 
> Testing
> -------
> 
> Everything is OK.
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130113/9be73305/attachment-0001.html>