[Marble-devel] Review Request 108383: Add a minimize option to the scale bar menu

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108383/#review25350
-----------------------------------------------------------



src/plugins/render/mapscale/MapScaleFloatItem.h
<http://git.reviewboard.kde.org/r/108383/#comment19350>

    I'd rather call it m_widthScaleFactor



src/plugins/render/mapscale/MapScaleFloatItem.cpp
<http://git.reviewboard.kde.org/r/108383/#comment19348>

    curly brackets missing



src/plugins/render/mapscale/MapScaleFloatItem.cpp
<http://git.reviewboard.kde.org/r/108383/#comment19349>

    Why not spare the m_minimized member variable and just use m_minimizedIndex?
    


- Dennis Nienhüser


On Jan. 13, 2013, 11:02 a.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108383/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2013, 11:02 a.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser, Torsten Rahn, and René Küttner.
> 
> 
> Description
> -------
> 
> Add a minimize option to the scale bar menu
> 
> * https://google-melange.appspot.com/gci/task/view/google/gci2012/8226206
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/mapscale/MapScaleConfigWidget.ui c8a217f 
>   src/plugins/render/mapscale/MapScaleFloatItem.h e3a2b8c 
>   src/plugins/render/mapscale/MapScaleFloatItem.cpp f22c940 
> 
> Diff: http://git.reviewboard.kde.org/r/108383/diff/
> 
> 
> Testing
> -------
> 
> Tested on Marble-Qt
> 
> 
> File Attachments
> ----------------
> 
> Config dialog
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/13/screen-alp-3.png
> Not minimized
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/13/screen-alp-1.png
> Minimized
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/13/screen-alp-2.png
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130113/ae62fe1f/attachment.html>