[Marble-devel] Review Request 108376: Writers for classes GeoDataLatLonAltBox and GeoDataLod

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108376/#review25323
-----------------------------------------------------------



src/lib/geodata/writers/kml/KmlGroundOverlayWriter.h
<http://git.reviewboard.kde.org/r/108376/#comment19319>

    Doesn't seem to change anything, so please remove this part :-)



src/lib/geodata/writers/kml/KmlLatLonAltBoxWriter.h
<http://git.reviewboard.kde.org/r/108376/#comment19321>

    Why would this inherit from KmlOverlayTagWriter? I'd understand it, if it inherited from KmlLatLonBoxWriter ...



src/lib/geodata/writers/kml/KmlLatLonAltBoxWriter.cpp
<http://git.reviewboard.kde.org/r/108376/#comment19322>

    if this class would inherit from KmlLatLonBoxWriter then you could just write:
    
    KmlLatLonBoxWriter::write(node, writer);
    
    .. and you'd save all the north, south, east and west lines.



src/lib/geodata/writers/kml/KmlLatLonAltBoxWriter.cpp
<http://git.reviewboard.kde.org/r/108376/#comment19323>

    see above



src/lib/geodata/writers/kml/KmlLatLonAltBoxWriter.cpp
<http://git.reviewboard.kde.org/r/108376/#comment19324>

    see above



src/lib/geodata/writers/kml/KmlLatLonAltBoxWriter.cpp
<http://git.reviewboard.kde.org/r/108376/#comment19325>

    see above



src/lib/geodata/writers/kml/KmlLodWriter.cpp
<http://git.reviewboard.kde.org/r/108376/#comment19320>

    Yes, that looks alright to me!


- Torsten Rahn


On Jan. 13, 2013, 12:01 a.m., Mayank Madan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108376/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2013, 12:01 a.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser and Torsten Rahn.
> 
> 
> Description
> -------
> 
> Writers for classes GeoDataLatLonAltBox and GeoDataLod
> 
> 
> Diffs
> -----
> 
>   src/lib/geodata/CMakeLists.txt e3f335d 
>   src/lib/geodata/writers/kml/KmlGroundOverlayWriter.h 86e2e9a 
>   src/lib/geodata/writers/kml/KmlLatLonAltBoxWriter.h PRE-CREATION 
>   src/lib/geodata/writers/kml/KmlLatLonAltBoxWriter.cpp PRE-CREATION 
>   src/lib/geodata/writers/kml/KmlLodWriter.h PRE-CREATION 
>   src/lib/geodata/writers/kml/KmlLodWriter.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/108376/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mayank Madan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130113/8065688a/attachment.html>