[Marble-devel] Review Request 108349: Implement support for the gx:Tour KML element

Dennis Nienhüser earthwings at gentoo.org
Sat Jan 12 23:16:22 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108349/#review25320
-----------------------------------------------------------

Ship it!



src/lib/geodata/data/GeoDataTour.cpp
<http://git.reviewboard.kde.org/r/108349/#comment19305>

    m_id



src/lib/geodata/handlers/kml/KmlPlacemarkTagHandler.cpp
<http://git.reviewboard.kde.org/r/108349/#comment19306>

    why this change?


- Dennis Nienhüser


On Jan. 11, 2013, 2:38 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108349/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2013, 2:38 p.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser, Torsten Rahn, and René Küttner.
> 
> 
> Description
> -------
> 
> * Implement support for the gx:Tour KML element
> 
> GCI: https://google-melange.appspot.com/gci/task/view/google/gci2012/8163205
> 
> 
> Diffs
> -----
> 
>   src/lib/geodata/CMakeLists.txt e3f335d 
>   src/lib/geodata/data/GeoDataTour.h PRE-CREATION 
>   src/lib/geodata/data/GeoDataTour.cpp PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlElementDictionary.h 16da3d3 
>   src/lib/geodata/handlers/kml/KmlElementDictionary.cpp 57d07d3 
>   src/lib/geodata/handlers/kml/KmlPlacemarkTagHandler.cpp 7ee1b02 
>   src/lib/geodata/handlers/kml/KmlTourTagHandler.h PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlTourTagHandler.cpp PRE-CREATION 
>   tests/TestTour.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/108349/diff/
> 
> 
> Testing
> -------
> 
> Everything is OK.
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130112/0b1c617b/attachment-0001.html>


More information about the Marble-devel mailing list