[Marble-devel] Review Request: Add a `drawOrder` kml xml tag handler

Dennis Nienhüser earthwings at gentoo.org
Fri Jan 11 09:48:44 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108342/#review25231
-----------------------------------------------------------

Ship it!


Ship It!

- Dennis Nienhüser


On Jan. 11, 2013, 9:40 a.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108342/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2013, 9:40 a.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser, Torsten Rahn, and René Küttner.
> 
> 
> Description
> -------
> 
> * Add a kml handler for drawOrder. Have it check the parent to be an Overlay and set its drawOrder value
> * Adjust TestScreenOverlay.cpp and TestGroundOverlay.cpp to test for different drawOrder values
> 
> -- according to the GCI task https://google-melange.appspot.com/gci/task/view/google/gci2012/8204206
> 
> 
> Diffs
> -----
> 
>   src/lib/geodata/CMakeLists.txt 3cb9e9e 
>   src/lib/geodata/handlers/kml/KmldrawOrderTagHandler.h PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmldrawOrderTagHandler.cpp PRE-CREATION 
>   tests/TestGroundOverlay.cpp 1ba7f1e 
>   tests/TestScreenOverlay.cpp 3ed85d0 
> 
> Diff: http://git.reviewboard.kde.org/r/108342/diff/
> 
> 
> Testing
> -------
> 
> Everything is OK.
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130111/4443d1aa/attachment.html>


More information about the Marble-devel mailing list