[Marble-devel] Review Request: KML GX:FLYTO HANDLER AND WRITER

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108260/#review24988
-----------------------------------------------------------



src/lib/geodata/data/GeoDataFlyTo.h
<http://git.reviewboard.kde.org/r/108260/#comment19134>

    GeoDataFlyTo shouldn't inherit GeoDataAbstractView, but inherit GeoDataObject and have getters/setters for  GeoDataAbstractView*.



src/lib/geodata/writers/kml/KmlFlyToTagWriter.cpp
<http://git.reviewboard.kde.org/r/108260/#comment19135>

    Here the view() -- see comment above -- of GeoDataFlyTo should be written (so that either KmlCameraTagWriter or KmlLookAtWriter will be called to write its value)


- Dennis Nienhüser


On Jan. 8, 2013, 3:46 p.m., Mayank Madan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108260/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2013, 3:46 p.m.)
> 
> 
> Review request for Marble and Dennis Nienhüser.
> 
> 
> Description
> -------
> 
> KML GX:FLYTO HANDLER AND WRITER
> 
> 
> Diffs
> -----
> 
>   src/lib/geodata/CMakeLists.txt 3cb9e9e 
>   src/lib/geodata/data/GeoDataFlyTo.h PRE-CREATION 
>   src/lib/geodata/data/GeoDataFlyTo.cpp PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlDurationTagHandler.h PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlDurationTagHandler.cpp PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlElementDictionary.h 16da3d3 
>   src/lib/geodata/handlers/kml/KmlElementDictionary.cpp 57d07d3 
>   src/lib/geodata/handlers/kml/KmlFlyToModeTagHandler.h PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlFlyToModeTagHandler.cpp PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlFlyToTagHandler.h PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlFlyToTagHandler.cpp PRE-CREATION 
>   src/lib/geodata/parser/GeoDataTypes.h 5155826 
>   src/lib/geodata/parser/GeoDataTypes.cpp 63bdbd9 
>   src/lib/geodata/writers/kml/KmlFlyToTagWriter.h PRE-CREATION 
>   src/lib/geodata/writers/kml/KmlFlyToTagWriter.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/108260/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mayank Madan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130108/5f1818c2/attachment-0001.html>