[Marble-devel] Review Request: Add Copy Menu and Shortcut to MapInfoDialog
Torsten Rahn
tackat at kde.org
Tue Jan 8 15:46:25 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108266/#review24983
-----------------------------------------------------------
src/lib/PopupItem.cpp
<http://git.reviewboard.kde.org/r/108266/#comment19133>
away, away ...
src/lib/PopupItem.cpp
<http://git.reviewboard.kde.org/r/108266/#comment19131>
Should this really be "ExtendedWebView"? Or rather "MarbleWebView". Shouldn't we share this webview class with the MarbleLegendBrowser?
src/lib/PopupItem.cpp
<http://git.reviewboard.kde.org/r/108266/#comment19132>
Nice!
- Torsten Rahn
On Jan. 8, 2013, 2:47 p.m., Illya Kovalevskyy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108266/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2013, 2:47 p.m.)
>
>
> Review request for Marble, Dennis Nienhüser, Torsten Rahn, and René Küttner.
>
>
> Description
> -------
>
> Add Copy Menu and Shortcut to MapInfoDialog according to the GCI task:
> - https://google-melange.appspot.com/gci/task/view/google/gci2012/8201211
>
>
> Diffs
> -----
>
> src/lib/PopupItem.h e4cabd8
> src/lib/PopupItem.cpp 970a88c
>
> Diff: http://git.reviewboard.kde.org/r/108266/diff/
>
>
> Testing
> -------
>
> Everything is OK.
>
>
> Screenshots
> -----------
>
> Disabled
> http://git.reviewboard.kde.org/r/108266/s/992/
> Enabled
> http://git.reviewboard.kde.org/r/108266/s/993/
>
>
> Thanks,
>
> Illya Kovalevskyy
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130108/56326946/attachment.html>
More information about the Marble-devel
mailing list