[Marble-devel] Review Request: Port the dynamically created <img> items of the MarbleLegendBrowser to QWebView

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108251/#review24939
-----------------------------------------------------------



src/lib/MarbleLegendBrowser.h
<http://git.reviewboard.kde.org/r/108251/#comment19122>

    superfluous



src/lib/MarbleLegendBrowser.cpp
<http://git.reviewboard.kde.org/r/108251/#comment19123>

    superfluous



src/lib/MarbleLegendBrowser.cpp
<http://git.reviewboard.kde.org/r/108251/#comment19124>

    should be commented out at least


- Torsten Rahn


On Jan. 7, 2013, 7:32 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108251/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2013, 7:32 p.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser and Torsten Rahn.
> 
> 
> Description
> -------
> 
> Port the dynamically created <img> items of the MarbleLegendBrowser to QWebView according to the GCI task:
>  - https://google-melange.appspot.com/gci/task/view/google/gci2012/8156208
> 
> 
> Diffs
> -----
> 
>   src/lib/LegendWidget.cpp a8306e2 
>   src/lib/LegendWidget.ui d3af4c8 
>   src/lib/MarbleLegendBrowser.h c526ff8 
>   src/lib/MarbleLegendBrowser.cpp 7c24689 
> 
> Diff: http://git.reviewboard.kde.org/r/108251/diff/
> 
> 
> Testing
> -------
> 
> Everything is OK.
> 
> 
> Screenshots
> -----------
> 
> Current View
>   http://git.reviewboard.kde.org/r/108251/s/989/
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130107/115e6714/attachment.html>