[Marble-devel] Review Request: Current Location button for Navigation FloatItem

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108238/#review24899
-----------------------------------------------------------



src/plugins/render/navigation/NavigationFloatItem.cpp
<http://git.reviewboard.kde.org/r/108238/#comment19111>

    "toggle" sounds like this method would show and hide the button depending on multiple calls. I guess it should rather be called
    
    toggleToCurrentPositionButton()



src/plugins/render/navigation/NavigationFloatItem.cpp
<http://git.reviewboard.kde.org/r/108238/#comment19112>

    see above
    
    toggleToHomeButton


- Torsten Rahn


On Jan. 7, 2013, 12:26 p.m., Mohammed Nafees wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108238/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2013, 12:26 p.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser, Torsten Rahn, and René Küttner.
> 
> 
> Description
> -------
> 
> http://www.google-melange.com/gci/task/view/google/gci2012/8191206
> 
> The home button has been extended in a way which now enables to switch buttons from home button to current location button and vice versa.
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/navigation/NavigationFloatItem.h 2eb71ce 
>   src/plugins/render/navigation/NavigationFloatItem.cpp 913253c 
>   src/plugins/render/navigation/navigation.qrc 14925ad 
>   src/plugins/render/navigation/navigation.ui 1f5c573 
> 
> Diff: http://git.reviewboard.kde.org/r/108238/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Mohammed Nafees
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130107/23884c0c/attachment.html>