[Marble-devel] Review Request: Current Location button for Navigation FloatItem

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108238/#review24890
-----------------------------------------------------------



src/plugins/render/navigation/NavigationFloatItem.cpp
<http://git.reviewboard.kde.org/r/108238/#comment19105>

    lacks the tr() method



src/plugins/render/navigation/NavigationFloatItem.cpp
<http://git.reviewboard.kde.org/r/108238/#comment19106>

    Lacks a tr() method. And an icon (gohome.png IIRC).



src/plugins/render/navigation/NavigationFloatItem.cpp
<http://git.reviewboard.kde.org/r/108238/#comment19107>

    Lacks a tr() method.



src/plugins/render/navigation/NavigationFloatItem.cpp
<http://git.reviewboard.kde.org/r/108238/#comment19108>

    Lacks a tr() method.



src/plugins/render/navigation/NavigationFloatItem.cpp
<http://git.reviewboard.kde.org/r/108238/#comment19104>

    This should be named centerOnCurrentLocation


- Torsten Rahn


On Jan. 7, 2013, 10:06 a.m., Mohammed Nafees wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108238/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2013, 10:06 a.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser, Torsten Rahn, and René Küttner.
> 
> 
> Description
> -------
> 
> http://www.google-melange.com/gci/task/view/google/gci2012/8191206
> 
> The home button has been extended in a way which now enables to switch buttons from home button to current location button and vice versa.
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/navigation/NavigationFloatItem.h 8446798 
>   src/plugins/render/navigation/NavigationFloatItem.cpp b6d9f26 
>   src/plugins/render/navigation/navigation.qrc 14925ad 
>   src/plugins/render/navigation/navigation.ui 1f5c573 
> 
> Diff: http://git.reviewboard.kde.org/r/108238/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Mohammed Nafees
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130107/1ca998e3/attachment.html>