[Marble-devel] Review Request: fixed foreach loops code checker issues

[Jens-Michael Hoffmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108217/#review24816
-----------------------------------------------------------



tests/RenderPluginTest.cpp
<http://git.reviewboard.kde.org/r/108217/#comment19055>

    Here it is not clear, if the container of the begin iterator is the same like the container of the end iterator. settings() might return a copy. Better get a reference to settings() and then use that for calling begin() and end().
    


- Jens-Michael Hoffmann


On Jan. 6, 2013, 12:55 p.m., Mohammed Nafees wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108217/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2013, 12:55 p.m.)
> 
> 
> Review request for KDE Edu, Marble and Kevin Krammer.
> 
> 
> Description
> -------
> 
> http://www.google-melange.com/gci/task/view/google/gci2012/8159207
> 
> fixed Krazy issues on foreach loops
> 
> 
> Diffs
> -----
> 
>   src/lib/FileManager.cpp 2bac816 
>   src/lib/StackedTileLoader.cpp 962bfef 
>   src/lib/routing/RouteAnnotator.cpp bf5e6f7 
>   src/plugins/render/opencaching/OpenCachingModel.cpp e333168 
>   tests/ProjectionTest.cpp ce6e5d1 
>   tests/RenderPluginTest.cpp f7dd2e3 
>   tests/TestGeoDataWriter.cpp a25ba95 
>   tests/TestGeoSceneWriter.cpp 222e22f 
>   tools/osm-addresses/OsmParser.cpp 1a24066 
> 
> Diff: http://git.reviewboard.kde.org/r/108217/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Mohammed Nafees
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130106/5343487a/attachment.html>