[Marble-devel] Review Request: fixed foreach loops code checker issues

[Jens-Michael Hoffmann]

Am Sonntag, 6. Januar 2013, 00:22:51 schrieb Mohammed Nafees:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108217/
> -----------------------------------------------------------
> 
> Review request for KDE Edu, Marble and Kevin Krammer.
> 
> 
> Description
> -------
> 
> http://www.google-melange.com/gci/task/view/google/gci2012/8159207
> 
> 
> Diffs
> -----
> 
>   src/lib/FileManager.cpp 2bac816
>   src/lib/StackedTileLoader.cpp 962bfef
>   src/lib/routing/RouteAnnotator.cpp bf5e6f7
>   src/plugins/render/opencaching/OpenCachingModel.cpp e333168
>   tests/ProjectionTest.cpp ce6e5d1
>   tests/RenderPluginTest.cpp f7dd2e3
>   tests/TestGeoDataWriter.cpp a25ba95
>   tests/TestGeoSceneWriter.cpp 222e22f
>   tools/osm-addresses/OsmParser.cpp 1a24066
> 
> Diff: http://git.reviewboard.kde.org/r/108217/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Mohammed Nafees

Please initialize iterators in the declaration. Otherwise the objects first 
get default constructed and then assigned.
In addition, it might be better to cache the "end" iterators.


kind regards,
Jens-Michael