[Marble-devel] Review Request: Allow to translate the constellation names in the stars plugin

Torsten Rahn tackat at kde.org
Fri Jan 4 12:37:30 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108162/#review24652
-----------------------------------------------------------



src/plugins/render/stars/StarsPlugin.h
<http://git.reviewboard.kde.org/r/108162/#comment18915>

    We prefer preincrement.  ++i - yupp not your fault.



src/plugins/render/stars/StarsPlugin.cpp
<http://git.reviewboard.kde.org/r/108162/#comment18916>

    Andromed -> Andromeda


- Torsten Rahn


On Jan. 4, 2013, 12:24 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108162/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2013, 12:24 p.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser, Torsten Rahn, and René Küttner.
> 
> 
> Description
> -------
> 
> Now it's allowed to translate the constellation names in the stars plugin:
>  - https://google-melange.appspot.com/gci/task/view/google/gci2012/8161203
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/stars/StarsConfigWidget.ui 6cfd8f4 
>   src/plugins/render/stars/StarsPlugin.h c536279 
>   src/plugins/render/stars/StarsPlugin.cpp 00420f0 
> 
> Diff: http://git.reviewboard.kde.org/r/108162/diff/
> 
> 
> Testing
> -------
> 
> Everything is OK.
> 
> 
> Screenshots
> -----------
> 
> Abbreviation OFF
>   http://git.reviewboard.kde.org/r/108162/s/969/
> Abbreviation ON
>   http://git.reviewboard.kde.org/r/108162/s/970/
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130104/e88ce4ee/attachment.html>


More information about the Marble-devel mailing list