[Marble-devel] Review Request: Get rid of PlacemarkInfoDialog and migrate the remaining placemarks

Torsten Rahn tackat at kde.org
Thu Jan 3 22:02:59 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108143/#review24621
-----------------------------------------------------------

Ship it!


Ship It!

- Torsten Rahn


On Jan. 3, 2013, 9:12 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108143/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2013, 9:12 p.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser, Torsten Rahn, and René Küttner.
> 
> 
> Description
> -------
> 
> Get rid of PlacemarkInfoDialog and migrate the remaining placemarks according to GCI task:
>  - http://www.google-melange.com/gci/task/view/google/gci2012/8156205
> 
> 
> Diffs
> -----
> 
>   src/lib/CMakeLists.txt cd82954 
>   src/lib/MarbleWidgetPopupMenu.h c3594c9 
>   src/lib/MarbleWidgetPopupMenu.cpp 13b37f9 
>   src/lib/PlacemarkInfoDialog.h d303984 
>   src/lib/PlacemarkInfoDialog.cpp 8c78b91 
>   src/lib/PlacemarkInfoDialog.ui 056fefd 
> 
> Diff: http://git.reviewboard.kde.org/r/108143/diff/
> 
> 
> Testing
> -------
> 
> Everything is OK.
> 
> 
> Screenshots
> -----------
> 
> Current View 1
>   http://git.reviewboard.kde.org/r/108143/s/967/
> Current View 2
>   http://git.reviewboard.kde.org/r/108143/s/968/
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130103/2ab224ad/attachment-0001.html>


More information about the Marble-devel mailing list